Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Changed implementation of slope calculation#1847

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Open
Haarush2006 wants to merge2 commits intoTheAlgorithms:master
base:master
Choose a base branch
Loading
fromHaarush2006:fix/DivisionByZero

Conversation

@Haarush2006
Copy link

Fix/

Changed implementation of slope calculation
Added cross product logic instead of math slope formula

fixes#1815

  • Fix a bug or typo in an existing algorithm?

Checklist:

  • I have readCONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new JavaScript files are placed inside an existing directory.
  • All filenames should use the UpperCamelCase (PascalCase) style. There should be no spaces in filenames.
    Example:UserProfile.js is allowed butuserprofile.js,Userprofile.js,user-Profile.js,userProfile.js are not
  • All new algorithms have a URL in their comments that points to Wikipedia or another similar explanation.
  • If this pull request resolves one or more open issues then the commit message containsFixes: #{$ISSUE_NO}.

@codecov-commenter
Copy link

codecov-commenter commentedOct 23, 2025•
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 85.91%. Comparing base (08d8c6b) to head (914e525).

Additional details and impacted files
@@            Coverage Diff             @@##           master    #1847      +/-   ##==========================================- Coverage   85.91%   85.91%   -0.01%==========================================  Files         379      379                Lines       19778    19772       -6       Branches     3015     3014       -1     ==========================================- Hits        16993    16987       -6  Misses       2785     2785

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report?Share it here.

🚀 New features to boost your workflow:
  • ❄️Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@Haarush2006
Copy link
Author

@appgurueu
@raklaptudirm
pls review my pr

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@raklaptudirmraklaptudirmAwaiting requested review from raklaptudirmraklaptudirm is a code owner

@appgurueuappgurueuAwaiting requested review from appgurueuappgurueu is a code owner

At least 2 approving reviews are required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[BUG]: ConvexHull algorithm crashes with division by zero on vertical lines

2 participants

@Haarush2006@codecov-commenter
[8]ページ先頭
©2009-2025 Movatter.jp