Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Added minimum window substring implementation and test file.#1821

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Open
Mayank29903 wants to merge2 commits intoTheAlgorithms:master
base:master
Choose a base branch
Loading
fromMayank29903:add-min-window-sub

Conversation

Mayank29903
Copy link

@Mayank29903Mayank29903 commentedOct 4, 2025
edited
Loading

  • Add an algorithm

Added theMinimum Window Substring algorithm in JavaScript, along with a test file.
This algorithm finds the smallest substring in a given string that contains all characters of another string.

Checklist:

  • I have readCONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new JavaScript files are placed inside an existing directory.
  • All filenames should use the UpperCamelCase (PascalCase) style. There should be no spaces in filenames.
    Example:UserProfile.js is allowed butuserprofile.js,Userprofile.js,user-Profile.js,userProfile.js are not
  • All new algorithms have a URL in their comments that points to Wikipedia or another similar explanation.
    Example:https://en.wikipedia.org/wiki/Minimum_window_substring
  • If this pull request resolves one or more open issues then the commit message containsFixes: #{$ISSUE_NO}

@codecov-commenter
Copy link

codecov-commenter commentedOct 4, 2025
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 85.94%. Comparing base (08d8c6b) to head (64137f5).

Additional details and impacted files
@@            Coverage Diff             @@##           master    #1821      +/-   ##==========================================+ Coverage   85.91%   85.94%   +0.02%==========================================  Files         379      380       +1       Lines       19778    19820      +42       Branches     3015     3027      +12     ==========================================+ Hits        16993    17035      +42  Misses       2785     2785

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report?Share it here.

🚀 New features to boost your workflow:
  • ❄️Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@Mayank29903
Copy link
Author

Screenshot 2025-10-04 134122

All the files follow prettier code format, still "code style" checkmark is not updating.

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@raklaptudirmraklaptudirmAwaiting requested review from raklaptudirmraklaptudirm is a code owner

@appgurueuappgurueuAwaiting requested review from appgurueuappgurueu is a code owner

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

2 participants
@Mayank29903@codecov-commenter

[8]ページ先頭

©2009-2025 Movatter.jp