Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

fix: improve mean function with input validation and extended tests#1785

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Open
FatihBARACKILIC wants to merge1 commit intoTheAlgorithms:master
base:master
Choose a base branch
Loading
fromFatihBARACKILIC:fix/improve-AverageMean

Conversation

FatihBARACKILIC
Copy link

Open in Gitpod know more

Describe your change:

  • Fix a bug or typo in an existing algorithm

This PR improves themean function by:

  • Adding input validation:
    • ThrowsTypeError if input is not an array or contains non-number elements
    • ThrowsError if array is empty
  • Adding a comprehensive test suite usingVitest, which includes:
    • Empty arrays
    • Invalid elements likenull,true,'string'
    • Floating-point numbers, negative values, large values
    • Mixed integer and float arrays

The function now adheres more strictly to the expected behavior and is more robust against invalid input.

Checklist:

  • I have readCONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new JavaScript files are placed inside an existing directory.
  • All filenames use the UpperCamelCase (PascalCase) style.
  • All new algorithms have a URL in their comments that points to Wikipedia or another similar explanation.

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.88%. Comparing base(1d252d7) to head(2b05c6b).

Additional details and impacted files
@@           Coverage Diff           @@##           master    #1785   +/-   ##=======================================  Coverage   85.87%   85.88%           =======================================  Files         377      377             Lines       19720    19731   +11       Branches     3005     3008    +3     =======================================+ Hits        16935    16946   +11  Misses       2785     2785

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report?Share it here.

🚀 New features to boost your workflow:
  • ❄️Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@raklaptudirmraklaptudirmAwaiting requested review from raklaptudirmraklaptudirm is a code owner

@appgurueuappgurueuAwaiting requested review from appgurueuappgurueu is a code owner

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

2 participants
@FatihBARACKILIC@codecov-commenter
[8]ページ先頭
©2009-2025 Movatter.jp