Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Added: Tarjan's SCC algorithm and test cases#1774

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Open
vedas-dixit wants to merge3 commits intoTheAlgorithms:master
base:master
Choose a base branch
Loading
fromvedas-dixit:tarjan-strongly-connected-components

Conversation

vedas-dixit
Copy link
Contributor

Pull Request Title:

Open in Gitpod Know more

Description of the Change:

I’ve implemented Tarjan’s Algorithm for finding Strongly Connected Components (SCC) in a directed graph, and added test cases to ensure correctness. This algorithm uses a depth-first search (DFS) approach and provides an efficient solution for identifying SCCs.

What did I do?

  • Implemented Tarjan's SCC algorithm.
  • Created test cases for validating the algorithm's correctness.
  • Ensured edge cases are covered in the test cases.

Checklist:

  • [*] I have read theCONTRIBUTING.md guidelines.
  • [*] This pull request is my own work and I have not plagiarized.
  • [*] I understand that pull requests will not be merged if they fail the automated tests.
  • [*] This PR only modifies the algorithm file related to Tarjan’s SCC.
  • [*] All new files follow the UpperCamelCase naming convention (e.g.,TarjanSCC.js).
  • [*] I’ve linked any algorithm-related references or explanations in the comments.

Let me know if any adjustments are needed!

@codecov-commenter
Copy link

codecov-commenter commentedApr 15, 2025•
edited
Loading

Codecov Report

Attention: Patch coverage is98.16514% with2 lines in your changes missing coverage. Please review.

Project coverage is 85.94%. Comparing base(1d252d7) to head(ae3b7fb).

Files with missing linesPatch %Lines
Graphs/TarjanSCC.js98.16%2 Missing⚠️
Additional details and impacted files
@@            Coverage Diff             @@##           master    #1774      +/-   ##==========================================+ Coverage   85.87%   85.94%   +0.06%==========================================  Files         377      378       +1       Lines       19720    19829     +109       Branches     3005     3028      +23     ==========================================+ Hits        16935    17042     +107- Misses       2785     2787       +2

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report?Share it here.

🚀 New features to boost your workflow:
  • ❄️Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@vedas-dixit
Copy link
ContributorAuthor

@appgurueu can you please review my pr and give feedback.
thanks.

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@raklaptudirmraklaptudirmAwaiting requested review from raklaptudirmraklaptudirm is a code owner

@appgurueuappgurueuAwaiting requested review from appgurueuappgurueu is a code owner

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

2 participants
@vedas-dixit@codecov-commenter
[8]ページ先頭
©2009-2025 Movatter.jp