Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork5.7k
feat: add tests for binary search trees#1769
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
raklaptudirm merged 1 commit intoTheAlgorithms:masterfromridge-kimani:feat/binary-search-tree-specsJan 15, 2025
Uh oh!
There was an error while loading.Please reload this page.
Merged
Changes fromall commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Uh oh!
There was an error while loading.Please reload this page.
Jump to
Jump to file
Failed to load files.
Loading
Uh oh!
There was an error while loading.Please reload this page.
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -36,13 +36,13 @@ const Node = (function Node() { | ||
| visit(output = (value) => console.log(value)) { | ||
| // Recursively go left | ||
| if (this.left !== null) { | ||
| this.left.visit(output) | ||
| } | ||
| // Print out value | ||
| output(this.value) | ||
| // Recursively go right | ||
| if (this.right !== null) { | ||
| this.right.visit(output) | ||
| } | ||
| } | ||
| @@ -116,20 +116,23 @@ const Tree = (function () { | ||
| } | ||
| // Inorder traversal | ||
| traverse(output = (value) => console.log(value)) { | ||
| if (!this.root) { | ||
| // No nodes are there in the tree till now | ||
| return | ||
| } | ||
| this.root.visit(output) | ||
| } | ||
| // Start by searching the root | ||
| search(val) { | ||
| if (this.root) { | ||
| const found = this.root.search(val) | ||
| if (found !== null) { | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others.Learn more. Just a shorthand recommendation. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others.Learn more. The search return value can only be search(val){if(this.value===val){returnthis}elseif(val<this.value&&this.left!==null){returnthis.left.search(val)}elseif(val>this.value&&this.right!==null){returnthis.right.search(val)}returnnull} | ||
| return found.value | ||
| } | ||
| } | ||
| // not found | ||
| return null | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,66 @@ | ||
| import { Tree } from '../BinarySearchTree.js' | ||
| describe('Binary Search Tree', () => { | ||
| let tree | ||
| beforeEach(() => { | ||
| tree = new Tree() | ||
| tree.addValue(10) | ||
| tree.addValue(5) | ||
| tree.addValue(15) | ||
| tree.addValue(3) | ||
| tree.addValue(8) | ||
| }) | ||
| test('should add values to the tree', () => { | ||
| tree.addValue(12) | ||
| expect(tree.search(12)).toBe(12) | ||
| expect(tree.search(5)).toBe(5) | ||
| expect(tree.search(15)).toBe(15) | ||
| }) | ||
| test('should perform in-order traversal', () => { | ||
| const values = [] | ||
| const output = (val) => values.push(val) | ||
| tree.traverse(output) | ||
| expect(values).toEqual([3, 5, 8, 10, 15]) | ||
| }) | ||
| test('should remove leaf nodes correctly', () => { | ||
| tree.removeValue(5) | ||
| expect(tree.search(5)).toBeNull() | ||
| }) | ||
| test('should remove nodes with one child correctly', () => { | ||
| tree.addValue(12) | ||
| tree.removeValue(15) | ||
| expect(tree.search(15)).toBeNull() | ||
| expect(tree.search(12)).toBe(12) | ||
| }) | ||
| test('should remove nodes with two children correctly', () => { | ||
| tree.addValue(18) | ||
| tree.removeValue(15) | ||
| expect(tree.search(15)).toBeNull() | ||
| expect(tree.search(18)).toBe(18) | ||
| }) | ||
| test('should return null for non-existent values', () => { | ||
| expect(tree.search(20)).toBeNull() | ||
| expect(tree.search(0)).toBeNull() | ||
| }) | ||
| test('should handle removal of root node correctly', () => { | ||
| tree.removeValue(10) | ||
| expect(tree.search(10)).toBeNull() | ||
| }) | ||
| test('should handle empty tree gracefully', () => { | ||
| const newTree = new Tree() | ||
| newTree.removeValue(22) // Should not throw | ||
| expect(newTree.search(22)).toBeNull() | ||
| }) | ||
| }) |
Oops, something went wrong.
Uh oh!
There was an error while loading.Please reload this page.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.