Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Added Miller Rabin Primality test#1748

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Open
Amal-Verma wants to merge4 commits intoTheAlgorithms:master
base:master
Choose a base branch
Loading
fromAmal-Verma:feat/added-miller-rabin-primality-test

Conversation

Amal-Verma
Copy link

Open in Gitpod know more

Describe your change:

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

Checklist:

  • I have readCONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new JavaScript files are placed inside an existing directory.
  • All filenames should use the UpperCamelCase (PascalCase) style. There should be no spaces in filenames.
    Example:UserProfile.js is allowed butuserprofile.js,Userprofile.js,user-Profile.js,userProfile.js are not
  • All new algorithms have a URL in their comments that points to Wikipedia or another similar explanation.
  • If this pull request resolves one or more open issues then the commit message containsFixes: #{$ISSUE_NO}.

@codecov-commenter
Copy link

codecov-commenter commentedOct 23, 2024•
edited
Loading

Codecov Report

Attention: Patch coverage is0% with70 lines in your changes missing coverage. Please review.

Project coverage is 84.46%. Comparing base(55ff0ad) to head(dcb2a73).

Files with missing linesPatch %Lines
Maths/MillerRabin.js0.00%70 Missing⚠️
Additional details and impacted files
@@            Coverage Diff             @@##           master    #1748      +/-   ##==========================================- Coverage   84.76%   84.46%   -0.30%==========================================  Files         378      379       +1       Lines       19738    19808      +70       Branches     2957     2958       +1     ==========================================  Hits        16731    16731- Misses       3007     3077      +70

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report?Share it here.

@Amal-Verma
Copy link
Author

@raklaptudirm@appgurueu Please review this PR

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@anandfreshanandfreshanandfresh approved these changes

@raklaptudirmraklaptudirmraklaptudirm approved these changes

@appgurueuappgurueuAwaiting requested review from appgurueuappgurueu is a code owner

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

4 participants
@Amal-Verma@codecov-commenter@anandfresh@raklaptudirm
[8]ページ先頭
©2009-2025 Movatter.jp