Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Feature/problem 26#1740

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Open
abda-gaye wants to merge4 commits intoTheAlgorithms:master
base:master
Choose a base branch
Loading
fromabda-gaye:feature/problem-26

Conversation

abda-gaye
Copy link

Describe your change:

  • Add an algorithm?

Checklist:

  • I have readCONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file.
  • All new JavaScript files are placed inside an existing directory.
  • All filenames use the UpperCamelCase (PascalCase) style.
    • Example:Problem026.js andProblem026.test.js are allowed.
  • All new algorithms have a URL in their comments that points to Wikipedia or another similar explanation.
  • If this pull request resolves one or more open issues, then the commit message containsFixes: #{$ISSUE_NO}

Algorithm Description

I have implemented a new algorithm in theProblem026.js file, along with a corresponding test fileProblem026.test.js to ensure its functionality. This algorithm addresses the problem described in the following link:Project Euler Problem 26.

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.85%. Comparing base(ff314a2) to head(c6192d7).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@##           master    #1740      +/-   ##==========================================+ Coverage   84.76%   84.85%   +0.08%==========================================  Files         378      380       +2       Lines       19742    19855     +113       Branches     2955     2978      +23     ==========================================+ Hits        16735    16848     +113  Misses       3007     3007

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report?Share it here.

@abda-gaye
Copy link
Author

abda-gaye commentedOct 20, 2024 via email

I think that it's goodLe dim. 20 oct. 2024 à 19:50, Codecov Comments Bot ***@***.***>a écrit :
…
Codecov <https://app.codecov.io/gh/TheAlgorithms/JavaScript/pull/1740?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=TheAlgorithms> Report All modified and coverable lines are covered by tests ✅ Project coverage is 84.85%. Comparing base (ff314a2) <https://app.codecov.io/gh/TheAlgorithms/JavaScript/commit/ff314a2bed38525af0445fde53e37338b4db3406?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=TheAlgorithms> to head (c6192d7) <https://app.codecov.io/gh/TheAlgorithms/JavaScript/commit/c6192d760d9d097352d49ccb49a76dd189309927?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=TheAlgorithms> . Report is 1 commits behind head on master. Additional details and impacted files @@ Coverage Diff @@## master#1740 +/- ## ==========================================+ Coverage 84.76% 84.85% +0.08% ========================================== Files 378 380 +2 Lines 19742 19855 +113 Branches 2955 2978 +23 ==========================================+ Hits 16735 16848 +113 Misses 3007 3007 ☔ View full report in Codecov by Sentry <https://app.codecov.io/gh/TheAlgorithms/JavaScript/pull/1740?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=TheAlgorithms> . 📢 Have feedback on the report? Share it here <https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=TheAlgorithms> . — Reply to this email directly, view it on GitHub <#1740 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AZGAU5ISXSHU72IAL4GUXUDZ4QCQFAVCNFSM6AAAAABQIZ2ANWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDIMRVGE4TGNRWGA> . You are receiving this because you authored the thread.Message ID: ***@***.***>

@abda-gaye
Copy link
Author

When are you going to look at my contribution?

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@raklaptudirmraklaptudirmAwaiting requested review from raklaptudirmraklaptudirm is a code owner

@appgurueuappgurueuAwaiting requested review from appgurueuappgurueu is a code owner

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

3 participants
@abda-gaye@codecov-commenter@gaye-lamine
[8]ページ先頭
©2009-2025 Movatter.jp