Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

docs: fixed misleading comment about the array method (forEach instead of reduce) used in AverageMean.js#1727

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged

Conversation

HRIDYANSHU054
Copy link
Contributor

@HRIDYANSHU054HRIDYANSHU054 commentedOct 10, 2024
edited
Loading

Open in Gitpod know more

Describe your change:

  • Documentation change?
    what was wrong?
    wrong array method in comment

Before:

// This loop sums all values in the 'nums' array using forEach loopconstsum=nums.reduce((sum,cur)=>sum+cur,0)

After:

// This calculates the sum of all values in the 'nums' array using reduce method.constsum=nums.reduce((sum,cur)=>sum+cur,0)

Checklist:

  • I have readCONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new JavaScript files are placed inside an existing directory.
  • All filenames should use the UpperCamelCase (PascalCase) style. There should be no spaces in filenames.
    Example:UserProfile.js is allowed butuserprofile.js,Userprofile.js,user-Profile.js,userProfile.js are not
  • All new algorithms have a URL in their comments that points to Wikipedia or another similar explanation.
  • If this pull request resolves one or more open issues then the commit message containsFixes: #{$ISSUE_NO}.

@codecov-commenter
Copy link

codecov-commenter commentedOct 10, 2024
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.76%. Comparing base(ff314a2) to head(d0e1ba9).

Additional details and impacted files
@@            Coverage Diff             @@##           master    #1727      +/-   ##==========================================- Coverage   84.76%   84.76%   -0.01%==========================================  Files         378      378                Lines       19742    19738       -4       Branches     2955     2957       +2     ==========================================- Hits        16735    16731       -4  Misses       3007     3007

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report?Share it here.

@appgurueu
Copy link
Collaborator

Just remove the comment. It adds no value.

@HRIDYANSHU054
Copy link
ContributorAuthor

@appgurueu Done.

Co-authored-by: Lars Müller <34514239+appgurueu@users.noreply.github.com>
@HRIDYANSHU054
Copy link
ContributorAuthor

@raklaptudirm please review the changes

@raklaptudirmraklaptudirm merged commit55ff0ad intoTheAlgorithms:masterOct 16, 2024
3 checks passed
@HRIDYANSHU054HRIDYANSHU054 deleted the fix/AverageMean branchOctober 17, 2024 04:56
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@appgurueuappgurueuappgurueu approved these changes

@anandfreshanandfreshanandfresh approved these changes

@raklaptudirmraklaptudirmraklaptudirm approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

5 participants
@HRIDYANSHU054@codecov-commenter@appgurueu@anandfresh@raklaptudirm

[8]ページ先頭

©2009-2025 Movatter.jp