Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Add tests for Project Euler Problem 5 + minor refactor#1691

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
appgurueu merged 23 commits intoTheAlgorithms:masterfrompomkarnath98:project-euler-5
Oct 8, 2024

Conversation

pomkarnath98
Copy link
Member

Open in Gitpod know more

Describe your change:

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

Checklist:

  • I have readCONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new JavaScript files are placed inside an existing directory.
  • All filenames should use the UpperCamelCase (PascalCase) style. There should be no spaces in filenames.
    Example:UserProfile.js is allowed butuserprofile.js,Userprofile.js,user-Profile.js,userProfile.js are not
  • All new algorithms have a URL in their comments that points to Wikipedia or another similar explanation.
  • If this pull request resolves one or more open issues then the commit message containsFixes: #{$ISSUE_NO}.

omkarnathparidaand others added14 commitsOctober 7, 2022 20:36
@codecov-commenter
Copy link

codecov-commenter commentedSep 28, 2024•
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.76%. Comparing base(5b17ea1) to head(f3afdbb).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@##           master    #1691      +/-   ##==========================================+ Coverage   84.65%   84.76%   +0.10%==========================================  Files         378      378                Lines       19744    19742       -2       Branches     2952     2956       +4     ==========================================+ Hits        16715    16735      +20+ Misses       3029     3007      -22

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report?Share it here.

@pomkarnath98
Copy link
MemberAuthor

@raklaptudirm@appgurueu I have formatted the code with Prettier. But the Codecov report says,2 lines in your changes missing coverage. What are we following now to avoid this?

@appgurueu
Copy link
Collaborator

As the codecov report shows, the trivial error check is not tested (seehttps://app.codecov.io/gh/TheAlgorithms/JavaScript/pull/1691/blob/Project-Euler/Problem005.js). I would probably just remove it.

pomkarnath98 reacted with thumbs up emoji

@pomkarnath98
Copy link
MemberAuthor

@appgurueu@raklaptudirm I think this PR now can be reviewed and merged.

raklaptudirm
raklaptudirm previously approved these changesOct 4, 2024
@pomkarnath98pomkarnath98 added the hacktoberfestCreated during hacktoberfest labelOct 5, 2024
@appgurueuappgurueu changed the titleProject Euler Problem 5Add tests for Project Euler Problem 5 + minor refactorOct 7, 2024
@appgurueuappgurueu merged commitff314a2 intoTheAlgorithms:masterOct 8, 2024
3 checks passed
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@appgurueuappgurueuappgurueu approved these changes

@raklaptudirmraklaptudirmAwaiting requested review from raklaptudirmraklaptudirm is a code owner

Assignees
No one assigned
Labels
hacktoberfestCreated during hacktoberfest
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

5 participants
@pomkarnath98@codecov-commenter@appgurueu@raklaptudirm@omkarnathparida
[8]ページ先頭
©2009-2025 Movatter.jp