NotificationsYou must be signed in to change notification settings
Fork5.7k
Star33.2k

chore: convert functions to an ES2015 classes#1656

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

raklaptudirm merged 2 commits intoTheAlgorithms:masterfromhasanalkaf3:master

Apr 13, 2024

Merged

chore: convert functions to an ES2015 classes#1656

raklaptudirm merged 2 commits intoTheAlgorithms:masterfromhasanalkaf3:master

Apr 13, 2024

Conversation

Copy link

Contributor

hasanalkaf3 commentedApr 7, 2024•
edited
Loading

know more

Describe your change:

Add an algorithm?
[ ✅ ] Fix a bug or typo in an existing algorithm?
Documentation change?

Checklist:

[ ✅ ] I have readCONTRIBUTING.md.
[ ✅ ] This pull request is all my own work -- I have not plagiarized.
[ ✅ ] I know that pull requests will not be merged if they fail the automated tests.
This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
[ ✅ ] All new JavaScript files are placed inside an existing directory.
[ ✅ ] All filenames should use the UpperCamelCase (PascalCase) style. There should be no spaces in filenames.
Example:UserProfile.js is allowed butuserprofile.js,Userprofile.js,user-Profile.js,userProfile.js are not
[ ✅ ] All new algorithms have a URL in their comments that points to Wikipedia or another similar explanation.
[ ✅ ] If this pull request resolves one or more open issues then the commit message containsFixes: #{$ISSUE_NO}.

chore: convert functions to an ES2015 classes

0144e77

hasanalkaf3 requested review fromraklaptudirm andappgurueu ascode owners

April 7, 2024 07:06

appgurueu reviewed

Apr 7, 2024

View reviewed changes

Copy link

Collaborator

appgurueu left a comment•
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Thanks for the refactor. In general, please try to get rid of the enclosing functions as well. Classes that are unnecessarily "nested" inside functions are confusing.