NotificationsYou must be signed in to change notification settings
Fork5.7k
Star33.2k

style: improve test names of`GetEuclidGCD`#1646

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

raklaptudirm merged 1 commit intoTheAlgorithms:masterfromvil02:improve_test_names

Mar 28, 2024

Merged

style: improve test names of`GetEuclidGCD`#1646

raklaptudirm merged 1 commit intoTheAlgorithms:masterfromvil02:improve_test_names

Mar 28, 2024

Conversation

Copy link

Member

vil02 commentedMar 25, 2024

know more

Describe your change:

While working on#1645 I have discovered'%o'. I decided to use it here. It should have been done in#1642.

Checklist:

I have readCONTRIBUTING.md.
This pull request is all my own work -- I have not plagiarized.
I know that pull requests will not be merged if they fail the automated tests.
This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
All new JavaScript files are placed inside an existing directory.
All filenames should use the UpperCamelCase (PascalCase) style. There should be no spaces in filenames.
Example:UserProfile.js is allowed butuserprofile.js,Userprofile.js,user-Profile.js,userProfile.js are not
All new algorithms have a URL in their comments that points to Wikipedia or another similar explanation.
If this pull request resolves one or more open issues then the commit message containsFixes: #{$ISSUE_NO}.

style: improve test names ofGetEuclidGCD'

f49f82c

vil02 marked this pull request as ready for review

March 25, 2024 19:52

vil02 requested review fromraklaptudirm andappgurueu ascode owners

March 25, 2024 19:52

Copy link

codecov-commenter commentedMar 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.07%. Comparing base(bd34e9f) to head(f49f82c).

Additional details and impacted files

@@           Coverage Diff           @@##           master    #1646   +/-   ##=======================================  Coverage   84.07%   84.07%           =======================================  Files         375      375             Lines       19688    19688             Branches     2913     2913           =======================================  Hits        16552    16552             Misses       3136     3136

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report?Share it here.