Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

refactor: add and useparseDate#1643

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
raklaptudirm merged 2 commits intoTheAlgorithms:masterfromvil02:add_parse_date
Apr 3, 2024

Conversation

vil02
Copy link
Member

Open in Gitpod know more

Describe your change:

Aspromissed, this PR adds a functionparseDate.

Checklist:

  • I have readCONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • All new JavaScript files are placed inside an existing directory.
  • All filenames should use the UpperCamelCase (PascalCase) style. There should be no spaces in filenames.
    Example:UserProfile.js is allowed butuserprofile.js,Userprofile.js,user-Profile.js,userProfile.js are not
  • If this pull request resolves one or more open issues then the commit message containsFixes: #{$ISSUE_NO}.

@vil02vil02 marked this pull request as ready for reviewMarch 18, 2024 16:32
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.07%. Comparing base(bd34e9f) to head(efeab6e).

Additional details and impacted files
@@           Coverage Diff           @@##           master    #1643   +/-   ##=======================================  Coverage   84.07%   84.07%           =======================================  Files         375      376    +1       Lines       19688    19694    +6       Branches     2913     2907    -6     =======================================+ Hits        16552    16558    +6  Misses       3136     3136

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report?Share it here.

appgurueu
appgurueu previously approved these changesMar 26, 2024
Copy link
Collaborator

@appgurueuappgurueu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Makes sense.

(Though probably these date-related functions should take "date" objects instead of strings in the first place to save them the (not very interesting) parsing.)

Co-authored-by: appgurueu <34514239+appgurueu@users.noreply.github.com>
@raklaptudirmraklaptudirm merged commit9c622dd intoTheAlgorithms:masterApr 3, 2024
@vil02vil02 deleted the add_parse_date branchApril 3, 2024 16:36
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@appgurueuappgurueuappgurueu approved these changes

@raklaptudirmraklaptudirmraklaptudirm approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

4 participants
@vil02@codecov-commenter@appgurueu@raklaptudirm
[8]ページ先頭
©2009-2025 Movatter.jp