Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork5.7k
feat: remove duplicatedgcd-like functions#1642
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Merged
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
codecov-commenter commentedMar 15, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@## master #1642 +/- ##==========================================+ Coverage 83.92% 84.07% +0.14%========================================== Files 376 375 -1 Lines 19698 19688 -10 Branches 2910 2914 +4 ==========================================+ Hits 16532 16552 +20+ Misses 3166 3136 -30 ☔ View full report in Codecov by Sentry. |
appgurueu approved these changesMar 15, 2024
raklaptudirm approved these changesMar 16, 2024
vil02 added a commit to vil02/JavaScript that referenced this pull requestMar 17, 2024
* feat: remove duplicated `gcd`-like functions* Updated Documentation in README.md---------Co-authored-by: vil02 <vil02@users.noreply.github.com>
8 tasks
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Labels
None yet
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe your change:
This PR removes theduplicated implementation ofrecursive gcd and moves an iterative one to
Maths.Checklist:
This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.Example:
UserProfile.jsis allowed butuserprofile.js,Userprofile.js,user-Profile.js,userProfile.jsare notFixes: #{$ISSUE_NO}.