Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

fix: hadnle zeros at the endpoints inBisectionMethod#1640

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged

Conversation

vil02
Copy link
Member

@vil02vil02 commentedMar 7, 2024•
edited
Loading

Open in Gitpod know more

Describe your change:

findRoot errors when one is trying to find a root forx^3 on the interval[-1, 1]. This PR fixes that and adds a testcave case covering:

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

Checklist:

  • I have readCONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new JavaScript files are placed inside an existing directory.
  • All filenames should use the UpperCamelCase (PascalCase) style. There should be no spaces in filenames.
    Example:UserProfile.js is allowed butuserprofile.js,Userprofile.js,user-Profile.js,userProfile.js are not
  • All new algorithms have a URL in their comments that points to Wikipedia or another similar explanation.
  • If this pull request resolves one or more open issues then the commit message containsFixes: #{$ISSUE_NO}.

@vil02vil02 marked this pull request as ready for reviewMarch 7, 2024 22:15
@codecov-commenter
Copy link

codecov-commenter commentedMar 7, 2024•
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.09%. Comparing base(bd34e9f) to head(f2f10bd).

Additional details and impacted files
@@            Coverage Diff             @@##           master    #1640      +/-   ##==========================================+ Coverage   84.07%   84.09%   +0.02%==========================================  Files         375      375                Lines       19688    19687       -1       Branches     2913     2914       +1     ==========================================+ Hits        16552    16556       +4+ Misses       3136     3131       -5

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report?Share it here.

@vil02vil02force-pushed thefix_bisection_method branch fromd4baaca toab6ffc9CompareMarch 17, 2024 18:33
@vil02vil02force-pushed thefix_bisection_method branch fromab6ffc9 tof2f10bdCompareMarch 17, 2024 18:39
raklaptudirm
raklaptudirm previously approved these changesMar 18, 2024
@vil02vil02 changed the titlefix: hadnle zeros at the endpointsfix: hadnle zeros at the endpointsBisectionMethodMar 18, 2024
@vil02vil02 changed the titlefix: hadnle zeros at the endpointsBisectionMethodfix: hadnle zeros at the endpoints inBisectionMethodMar 18, 2024
appgurueu
appgurueu previously approved these changesMar 26, 2024
Copy link
Collaborator

@appgurueuappgurueu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Math.pow(x, n) can be written asx**n btw, so you could simply writex => x ** 2 for example.

vil02 reacted with thumbs up emoji
Co-authored-by: appgurueu <34514239+appgurueu@users.noreply.github.com>
@raklaptudirmraklaptudirm merged commit34a663a intoTheAlgorithms:masterApr 3, 2024
@vil02vil02 deleted the fix_bisection_method branchApril 3, 2024 16:36
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@appgurueuappgurueuappgurueu approved these changes

@raklaptudirmraklaptudirmraklaptudirm approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

4 participants
@vil02@codecov-commenter@appgurueu@raklaptudirm
[8]ページ先頭
©2009-2025 Movatter.jp