NotificationsYou must be signed in to change notification settings
Fork5.7k
Star33.2k

refactor: use`isLeapYear`#1638

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

raklaptudirm merged 1 commit intoTheAlgorithms:masterfromvil02:use_isLeapYear

Mar 7, 2024

Merged

refactor: use`isLeapYear`#1638

raklaptudirm merged 1 commit intoTheAlgorithms:masterfromvil02:use_isLeapYear

Mar 7, 2024

Conversation

Copy link

Member

vil02 commentedMar 5, 2024

know more

Describe your change:

This PR:

applies theisLeapYear,
reorganizes the tests ofGetMonthDays - note the change of the year in one of the test cases (I do not want to create an illusion that this function should be uses for years before 1582).

Checklist:

I have readCONTRIBUTING.md.
This pull request is all my own work -- I have not plagiarized.
I know that pull requests will not be merged if they fail the automated tests.
~~This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.~~
All new JavaScript files are placed inside an existing directory.
All filenames should use the UpperCamelCase (PascalCase) style. There should be no spaces in filenames.
Example:UserProfile.js is allowed butuserprofile.js,Userprofile.js,user-Profile.js,userProfile.js are not
All new algorithms have a URL in their comments that points to Wikipedia or another similar explanation.
If this pull request resolves one or more open issues then the commit message containsFixes: #{$ISSUE_NO}.

Copy link

codecov-commenter commentedMar 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.94%. Comparing base(d8cfdcd) to head(66ab291).

Additional details and impacted files

@@           Coverage Diff           @@##           master    #1638   +/-   ##=======================================  Coverage   83.93%   83.94%           =======================================  Files         377      377             Lines       19733    19727    -6       Branches     2921     2918    -3     =======================================- Hits        16563    16559    -4+ Misses       3170     3168    -2

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report?Share it here.

vil02 marked this pull request as ready for review

March 5, 2024 18:21

vil02 requested review fromraklaptudirm andappgurueu ascode owners

March 5, 2024 18:21

vil02 marked this pull request as draft

March 5, 2024 18:22

vil02 force-pushed theuse_isLeapYear branch from66ab291 tob4d05b4Compare

March 5, 2024 18:25

vil02 marked this pull request as ready for review

March 5, 2024 18:27

vil02 force-pushed theuse_isLeapYear branch 2 times, most recently fromc523049 to5faf0a5Compare

March 5, 2024 18:34

appgurueu approved these changes

Mar 5, 2024

View reviewed changes

Copy link

MemberAuthor

vil02 commentedMar 5, 2024

@appgurueu or@raklaptudirm could you please re-run theUploadCoverageReport (if needed). It failed due to:The server encountered a temporary error and could not complete your request.