Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

[DO NOT MERGE before adding the token] chore: updatecodecov-action tov4#1605

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged

Conversation

vil02
Copy link
Member

Open in Gitpod know more

Describe your change:

Same asTheAlgorithms/Rust#670 - it contains the description of the problem.

Before merging, please add the token fromhttps://app.codecov.io/gh/TheAlgorithms/JavaScript/settings asCODECOV_TOKEN into the repo secrets.

Checklist:

  • I have readCONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.

@vil02vil02 marked this pull request as ready for reviewFebruary 2, 2024 18:42
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base(6aaa376) 82.44% compared to head(8176408) 82.44%.

Additional details and impacted files
@@           Coverage Diff           @@##           master    #1605   +/-   ##=======================================  Coverage   82.44%   82.44%           =======================================  Files         377      377             Lines       19747    19747             Branches     2884     2885    +1     =======================================  Hits        16281    16281             Misses       3466     3466

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report?Share it here.

@appgurueu
Copy link
Collaborator

It seems that in order to add the token, I would have to be logged in (on the codecov site) to accesshttps://app.codecov.io/gh/TheAlgorithms/JavaScript/settings ? I'm slightly uncomfortable with this as it requests permission to "act on my behalf":

Screenshot from 2024-02-02 20-47-06

@vil02
Copy link
MemberAuthor

It seems that in order to add the token, I would have to be logged in (on the codecov site) to accesshttps://app.codecov.io/gh/TheAlgorithms/JavaScript/settings ?

Yes.

I'm slightly uncomfortable with this as it requests permission to "act on my behalf":

I agree.

@appgurueu
Copy link
Collaborator

I bit the bullet and authorized CodeCov to obtain the token, but it turns out that I can't edit repo secrets since I do not have "admin" permissions. This will require@Panquesito7 or@AnupKumarPanwar I believe.

vil02 reacted with thumbs up emoji

@raklaptudirm
Copy link
Member

@appgurueu You should have admin access to the repository now

@appgurueuappgurueu merged commit9010481 intoTheAlgorithms:masterJun 23, 2024
@vil02
Copy link
MemberAuthor

Just in case: please make sure thatCODECOV_TOKEN is also added to the dependabot secrets (6e27235 adds dependabot).

@vil02vil02 deleted the update_codecov_action_to_v4 branchJune 23, 2024 12:19
@appgurueu
Copy link
Collaborator

Just in case: please make sure thatCODECOV_TOKEN is also added to the dependabot secrets (6e27235 adds dependabot).

Why would dependabot need the codecov token? It seems to work as-is:https://app.codecov.io/github/TheAlgorithms/JavaScript/commit/9010481c2930d65621f18f41c216f29fceaa8807

@vil02
Copy link
MemberAuthor

Without it, theUploadCoverageReport will fail for each PR created by dependabot.

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@raklaptudirmraklaptudirmAwaiting requested review from raklaptudirmraklaptudirm is a code owner

@appgurueuappgurueuAwaiting requested review from appgurueuappgurueu is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

4 participants
@vil02@codecov-commenter@appgurueu@raklaptudirm

[8]ページ先頭

©2009-2025 Movatter.jp