Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

tests: add tests forSHA256#1604

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged

Conversation

vil02
Copy link
Member

Open in Gitpod know more

Describe your change:

This PR adds tests forSHA256.
The data was verified withhttps://emn178.github.io/online-tools/sha256.html.

Similar to#1602.

  • Add missing tests.

Checklist:

  • I have readCONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new JavaScript files are placed inside an existing directory.
  • All filenames should use the UpperCamelCase (PascalCase) style. There should be no spaces in filenames.
    Example:UserProfile.js is allowed butuserprofile.js,Userprofile.js,user-Profile.js,userProfile.js are not
  • All new algorithms have a URL in their comments that points to Wikipedia or another similar explanation.
  • If this pull request resolves one or more open issues then the commit message containsFixes: #{$ISSUE_NO}.

@vil02vil02 marked this pull request as ready for reviewFebruary 1, 2024 18:10
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base(6aaa376) 82.44% compared to head(dbabed8) 83.44%.

Additional details and impacted files
@@            Coverage Diff             @@##           master    #1604      +/-   ##==========================================+ Coverage   82.44%   83.44%   +0.99%==========================================  Files         377      377                Lines       19747    19747                Branches     2884     2906      +22     ==========================================+ Hits        16281    16477     +196+ Misses       3466     3270     -196

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report?Share it here.

Copy link
Collaborator

@appgurueuappgurueu left a comment•
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Verified using thesha256sum command.

vil02 reacted with thumbs up emoji
@raklaptudirmraklaptudirm merged commitf313498 intoTheAlgorithms:masterFeb 9, 2024
@vil02vil02 deleted the add_tests_for_sha256 branchFebruary 9, 2024 20:17
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@appgurueuappgurueuappgurueu approved these changes

@raklaptudirmraklaptudirmraklaptudirm approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

4 participants
@vil02@codecov-commenter@appgurueu@raklaptudirm
[8]ページ先頭
©2009-2025 Movatter.jp