Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

tests: add tests forSHA1#1602

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
raklaptudirm merged 2 commits intoTheAlgorithms:masterfromvil02:add_tests_for_sha1
Jan 31, 2024

Conversation

vil02
Copy link
Member

@vil02vil02 commentedJan 29, 2024•
edited
Loading

Open in Gitpod know more

Describe your change:

This PR adds test forSHA1. The test data comes fromwikipeda or was verified withhttp://www.sha1-online.com/

  • Add missing tests.

Checklist:

  • I have readCONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new JavaScript files are placed inside an existing directory.
  • All filenames should use the UpperCamelCase (PascalCase) style. There should be no spaces in filenames.
    Example:UserProfile.js is allowed butuserprofile.js,Userprofile.js,user-Profile.js,userProfile.js are not
  • If this pull request resolves one or more open issues then the commit message containsFixes: #{$ISSUE_NO}.

@codecov-commenter
Copy link

codecov-commenter commentedJan 29, 2024•
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base(cf00041) 81.55% compared to head(9c5e0e4) 82.44%.

Additional details and impacted files
@@            Coverage Diff             @@##           master    #1602      +/-   ##==========================================+ Coverage   81.55%   82.44%   +0.89%==========================================  Files         377      377                Lines       19747    19747                Branches     2865     2884      +19     ==========================================+ Hits        16105    16281     +176+ Misses       3642     3466     -176

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report?Share it here.

@vil02vil02 marked this pull request as ready for reviewJanuary 29, 2024 16:10
appgurueu
appgurueu previously approved these changesJan 29, 2024
Copy link
Collaborator

@appgurueuappgurueu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Otherwise fine.

vil02 reacted with thumbs up emoji
---------Co-authored-by: appgurueu <34514239+appgurueu@users.noreply.github.com>
@raklaptudirmraklaptudirm merged commit6aaa376 intoTheAlgorithms:masterJan 31, 2024
@vil02vil02 deleted the add_tests_for_sha1 branchJanuary 31, 2024 21:57
@vil02vil02 mentioned this pull requestFeb 1, 2024
9 tasks
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@appgurueuappgurueuappgurueu approved these changes

@raklaptudirmraklaptudirmraklaptudirm approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

4 participants
@vil02@codecov-commenter@appgurueu@raklaptudirm
[8]ページ先頭
©2009-2025 Movatter.jp