Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Test cases project euler#1575

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Open
pomkarnath98 wants to merge18 commits intoTheAlgorithms:master
base:master
Choose a base branch
Loading
frompomkarnath98:test-cases-project-euler

Conversation

pomkarnath98
Copy link
Member

Open in Gitpod know more

Describe your change:

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

Checklist:

  • I have readCONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new JavaScript files are placed inside an existing directory.
  • All filenames should use the UpperCamelCase (PascalCase) style. There should be no spaces in filenames.
    Example:UserProfile.js is allowed butuserprofile.js,Userprofile.js,user-Profile.js,userProfile.js are not
  • All new algorithms have a URL in their comments that points to Wikipedia or another similar explanation.
  • If this pull request resolves one or more open issues then the commit message containsFixes: #{$ISSUE_NO}.

omkarnathparidaand others added16 commitsOctober 7, 2022 20:36
@pomkarnath98
Copy link
MemberAuthor

pomkarnath98 commentedOct 24, 2023•
edited
Loading

@appgurueu@raklaptudirm I have added the test cases for all the existingProject Euler problem solutions. All the remaining problems need to be solved which we'll be solving gradually.

Already created existing PRs for theProject Euler problemsProblem 4,Problem 5,Problem 6,Problem 9 can be checked as well.

Kindly verify and merge the PRs, if looks good.

@pomkarnath98pomkarnath98 mentioned this pull requestOct 25, 2023
11 tasks
Copy link
Member

@raklaptudirmraklaptudirm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Pr seems to have lots of unrelated changes which should be removed.

import { latticePath } from '../Problem015.js'

describe('Lattice Paths', () => {
test('if grid size is 2', () => {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Such repetitive tests should usetest.each /it.each to reduce the boilerplate.

@mohmmadAyesh
Copy link

@appgurueu Hi I want to contribute to make the last request changes is this PR available ?

@appgurueu
Copy link
Collaborator

@mohmmadAyesh I think you'd have to ask@pomkarnath98 that.

@mohmmadAyesh
Copy link

@pomkarnath98 is this pull request still open can i contribute to continue suggested changes?

@pomkarnath98
Copy link
MemberAuthor

pomkarnath98 commentedApr 8, 2024 via email

Hey, sorry for the late reply.Please feel free to contribute to the PR 👍
…
------------------------Regards,Omkarnath Parida
On Wed, Mar 27, 2024 at 2:39 AM mohmmad ayesh ***@***.***> wrote:@pomkarnath98 <https://github.com/pomkarnath98> is this pull request still open can i contribute to continue suggested changes? — Reply to this email directly, view it on GitHub <#1575 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AKEJWPJSVFIBE265TNUDU6TY2HIZNAVCNFSM6AAAAAA6N2GBEOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDAMRRGQ3TSNZXGM> . You are receiving this because you were mentioned.Message ID: ***@***.***>

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@appgurueuappgurueuappgurueu left review comments

@raklaptudirmraklaptudirmraklaptudirm requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

5 participants
@pomkarnath98@mohmmadAyesh@appgurueu@raklaptudirm@omkarnathparida
[8]ページ先頭
©2009-2025 Movatter.jp