Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Implemented M Coloring Problem#1562

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged

Conversation

vedas-dixit
Copy link
Contributor

@vedas-dixitvedas-dixit commentedOct 22, 2023•
edited
Loading

Open in Gitpod know more

Describe your change:

  • [x ] Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

Checklist:

  • I have readCONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • [x ] This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • [x ] All new JavaScript files are placed inside an existing directory.
  • All filenames should use the UpperCamelCase (PascalCase) style. There should be no spaces in filenames.
    Example:UserProfile.js is allowed butuserprofile.js,Userprofile.js,user-Profile.js,userProfile.js are not
  • All new algorithms have a URL in their comments that points to Wikipedia or another similar explanation.
  • If this pull request resolves one or more open issues then the commit message containsFixes: #{$ISSUE_NO}.

Copy link
Collaborator

@appgurueuappgurueu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

It also seems to me that an adjacency list representation would be more suitable?

@vedas-dixit
Copy link
ContributorAuthor

Thank you@appgurueu for the detailed review. I appreciate the feedback and suggestions. I'll work on implementing the changes you recommended:

I'll consider switching to an adjacency list representation for better efficiency.
I'll refine the comments, utilize proper JS Doc comments, and ensure that explanations are placed next to the relevant code.
I'll revisit the class-based approach and try to refactor it to a functional one as you suggested.
I'll push these changes soon. Thanks again for the insights!

appgurueu reacted with thumbs up emoji

Use proper JSDoc comments.Refine the comments and remove redundancies.
@raklaptudirmraklaptudirm merged commitfb134b1 intoTheAlgorithms:masterOct 24, 2023
@vedas-dixitvedas-dixit deleted the m-coloring-backtracking branchOctober 26, 2023 06:26
@vedas-dixitvedas-dixit restored the m-coloring-backtracking branchOctober 26, 2023 06:26
@vedas-dixitvedas-dixit deleted the m-coloring-backtracking branchOctober 26, 2023 06:28
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@appgurueuappgurueuappgurueu approved these changes

@raklaptudirmraklaptudirmraklaptudirm approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

3 participants
@vedas-dixit@appgurueu@raklaptudirm
[8]ページ先頭
©2009-2025 Movatter.jp