Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork5.8k
Update AllCombinationsOfSizeK.js#1530
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
appgurueu left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Looks good, however formatting seems broken. If you're already refactoring this, could you get rid of the class entirely? This should be a single function takingn andk as parameters instead. Ideally the API should also be a generator rather than producing a list.
appgurueu left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
You'll need to fix the tests, though. They currently still expect a class.
Changes made it the type of testing. Instead of testing the class now the program will test the function
imrahulkb commentedOct 29, 2023
I am not able to get that why there is code style error in this pull request |
Uh oh!
There was an error while loading.Please reload this page.
Describe your change:
This PR modifies a current algorithm forAllCombinationsOfSizeK. Four parameters made up the originalfindCombinations() method, and they were duplicated for each stack call. Since the modifications are kept in the instance variables, the modifiedfindCombinations() method does not require any parameters. In this case, there will befar fewer local variables that need to be initialized overall on each recursive call.
There was also a for loop in the original technique. The updates function isentirely recursive and lacks a for loop.
Checklist:
Example:
UserProfile.jsis allowed butuserprofile.js,Userprofile.js,user-Profile.js,userProfile.jsare notFixes: #{$ISSUE_NO}.