Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

feat: Added MD5 hashing algorithm#1519

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
raklaptudirm merged 16 commits intoTheAlgorithms:masterfromManpreetXSingh:md5
Oct 30, 2023
Merged

feat: Added MD5 hashing algorithm#1519

raklaptudirm merged 16 commits intoTheAlgorithms:masterfromManpreetXSingh:md5
Oct 30, 2023

Conversation

@ManpreetXSingh
Copy link
Contributor

@ManpreetXSinghManpreetXSingh commentedOct 12, 2023•
edited
Loading

Open in Gitpod know more

Describe your change:

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

Checklist:

  • I have readCONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new JavaScript files are placed inside an existing directory.
  • All filenames should use the UpperCamelCase (PascalCase) style. There should be no spaces in filenames.
    Example:UserProfile.js is allowed butuserprofile.js,Userprofile.js,user-Profile.js,userProfile.js are not
  • All new algorithms have a URL in their comments that points to Wikipedia or another similar explanation.
  • If this pull request resolves one or more open issues then the commit message containsFixes: #{$ISSUE_NO}.

Copy link
Collaborator

@appgurueuappgurueu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

The code is pretty messy because it juggles various representations of bytes that aren't really suitable (strings of bits encoded as ASCII 0 / 1 etc.)
It should be changed to just useUint8Array wherever byte arrays are needed, and simply numbers wherever 4 byte "words" are needed. The string representations (and the code for dealing with them) should be gotten rid of entirely.

Also needs tests.

@ManpreetXSingh
Copy link
ContributorAuthor

Hi@appgurueu,
Thanks for the feedback!
Actually I'm quite new to the js world. I looked at the SHA implementations in the nearby files and assumed that it's the right way to do it. I'll try my best to fix the issues and make the code cleaner.

@appgurueu
Copy link
Collaborator

[...] I looked at the SHA implementations in the nearby files and assumed that it's the right way to do it. [...]

Ah, sorry about that. We have much legacy code lying around that needs to be refactored and definitely isn't a good example. We should make it more clear in the contribution guidelines that much of the legacy codebase shouldn't be taken as a good example.

ManpreetXSingh reacted with thumbs up emoji

@ManpreetXSingh
Copy link
ContributorAuthor

Hi@appgurueu,
I believe I have implemented all of the requested changes. Please let me know if any additional adjustments are needed.

@appgurueuappgurueu added the hacktoberfest-acceptedAccepted to be counted towards Hacktoberfest labelOct 28, 2023
@appgurueu
Copy link
Collaborator

Adding the hacktoberfest-accepted label in case we don't get this merged before October ends; the PR is almost there!

raklaptudirm and ManpreetXSingh reacted with thumbs up emoji

@raklaptudirmraklaptudirm merged commit889d9c3 intoTheAlgorithms:masterOct 30, 2023
@ManpreetXSingh
Copy link
ContributorAuthor

ManpreetXSingh commentedOct 30, 2023•
edited
Loading

Thanks! 😊

@appgurueu
Copy link
Collaborator

Thank you for your contribution!

ManpreetXSingh reacted with thumbs up emoji

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@appgurueuappgurueuappgurueu approved these changes

@raklaptudirmraklaptudirmraklaptudirm approved these changes

Assignees

No one assigned

Labels

hacktoberfest-acceptedAccepted to be counted towards Hacktoberfest

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ManpreetXSingh@appgurueu@raklaptudirm
[8]ページ先頭
©2009-2025 Movatter.jp