NotificationsYou must be signed in to change notification settings
Fork5.7k
Star33.2k

bug: abs returns 0 on an empty array#1473

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

raklaptudirm merged 3 commits intoTheAlgorithms:masterfromridge-kimani:bug/abs-test-case

Oct 10, 2023

Merged

bug: abs returns 0 on an empty array#1473

raklaptudirm merged 3 commits intoTheAlgorithms:masterfromridge-kimani:bug/abs-test-case

Oct 10, 2023

Conversation

Copy link

Contributor

ridge-kimani commentedOct 7, 2023

know more

Describe your change:

Updates an edge case to return invalid type on objects
Fix a bug or typo in an existing algorithm?

Checklist:

I have readCONTRIBUTING.md.
This pull request is all my own work -- I have not plagiarized.
I know that pull requests will not be merged if they fail the automated tests.
This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
All new JavaScript files are placed inside an existing directory.
All filenames should use the UpperCamelCase (PascalCase) style. There should be no spaces in filenames.
Example:UserProfile.js is allowed butuserprofile.js,Userprofile.js,user-Profile.js,userProfile.js are not
All new algorithms have a URL in their comments that points to Wikipedia or another similar explanation.
If this pull request resolves one or more open issues then the commit message containsFixes: #{$ISSUE_NO}.

rnkimani added3 commits

October 7, 2023 17:20

bug: update edge case for empty array

240f720

bug: add edge case for empty arrays

760b7d3

feat: add test case for empty array

4dee86b

ridge-kimani requested review fromraklaptudirm andappgurueu ascode owners

October 7, 2023 14:40

appgurueu approved these changes

Oct 8, 2023

View reviewed changes

Copy link

Collaborator

appgurueu left a comment•
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Not opposed to this as it seems to fix an edge case the author hadn't considered.

abs(null) will still be0 due to the coercion of+. Types should probably be checked before coercing, otherwise it makes the most sense to accept JS coercion rules.

Frankly I think thisAbs function is a mess without algorithmic value though. I think it would probably be best to remove it.

Copy link

ContributorAuthor

ridge-kimani commentedOct 8, 2023

abs(null) will still be caught by the object check sincetypeof null isobject

Copy link

Collaborator

appgurueu commentedOct 8, 2023•
edited
Loading

abs(null) will still be caught by the object check sincetypeof null isobject

That's true, I missed this. As said, I approve this PR, it makes the function be closer to what the interface was supposed to be. But that interface doesn't make a whole lot of sense. It should coerce some types, but not others? The interface of this function is inconsistent both with JavaScript coercion and with sane strict behavior. The function also is algorithmically trivial, so we should probably weed it out sooner or later.

In the future, we should either have (1) strict type checks (in this case: only allow a number) or (2) preferably, no overly defensive type checks, as is idiomatic in JavaScript, and simply assuming the user knows what (not) to do (which of course needs to be documented properly).