Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Fixes-the-Grammar-Mistake#1453

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
appgurueu merged 2 commits intoTheAlgorithms:masterfromAbhineshJha:GrammarError
Oct 7, 2023
Merged

Fixes-the-Grammar-Mistake#1453

appgurueu merged 2 commits intoTheAlgorithms:masterfromAbhineshJha:GrammarError
Oct 7, 2023

Conversation

AbhineshJha
Copy link
Contributor

@AbhineshJhaAbhineshJha commentedOct 5, 2023•
edited
Loading

Describe your change:

@AbhineshJha
Copy link
ContributorAuthor

AbhineshJha commentedOct 6, 2023•
edited
Loading

please review@raklaptudirm@appgurueu

Copy link
Collaborator

@appgurueuappgurueu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Quoting theHacktoberfest website:

Avoid submitting low-quality pull/merge requests.

This is a fix for a typo in a comment. It doesn't affect the code or even the meaning of the comment at all. I'm afraid this pretty much makes it a textbook low quality contribution.

We do welcome chores like fixing typos, but please do them in bulk to reduce overhead, and don't expect them to count towards your Hacktoberfest score.

@appgurueuappgurueu added the hacktoberfest-invalidnot eligible to count towards hacktoberfest points labelOct 7, 2023
@raklaptudirm
Copy link
Member

@appgurueu Even though this can't be accepted for hacktoberfest please approve the changes so we can merge.

@AbhineshJha
Copy link
ContributorAuthor

AbhineshJha commentedOct 7, 2023•
edited
Loading

sorry for inconvenience@appgurueu ! I am new to open source , i am in the learning period , next time this will not happen

@AbhineshJha
Copy link
ContributorAuthor

hey@raklaptudirm merge this !!

@appgurueu
Copy link
Collaborator

sorry for inconvenience@appgurueu ! I am new to open source , i am in the learning period , next time this will not happen

That's fine. I suggest you to carefully reread the Hacktoberfest site to know the "rules" as a participant.

I will merge this for now (but I don't think it will count towards Hacktoberfest, given the label matching\binvalid\b), but in the future, please don't make PRs to fix single typos; it has way too much overhead. If you do decide to fix typos, fix multiple in one go.

@appgurueuappgurueu merged commitda0ee87 intoTheAlgorithms:masterOct 7, 2023
@AbhineshJhaAbhineshJha deleted the GrammarError branchOctober 7, 2023 18:45
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@pertrai1pertrai1pertrai1 left review comments

@appgurueuappgurueuappgurueu approved these changes

@raklaptudirmraklaptudirmraklaptudirm approved these changes

Assignees
No one assigned
Labels
hacktoberfest-invalidnot eligible to count towards hacktoberfest points
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[OTHER]: Grammar Mistake
4 participants
@AbhineshJha@raklaptudirm@appgurueu@pertrai1
[8]ページ先頭
©2009-2025 Movatter.jp