Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

feat: add MergeTwoSortedLinkedLIsts algorithms#1442

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
raklaptudirm merged 3 commits intoTheAlgorithms:masterfromahnge:master
Oct 11, 2023

Conversation

ahnge
Copy link
Contributor

Open in Gitpod know more

Describe your change:

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

Checklist:

  • I have readCONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new JavaScript files are placed inside an existing directory.
  • All filenames should use the UpperCamelCase (PascalCase) style. There should be no spaces in filenames.
    Example:UserProfile.js is allowed butuserprofile.js,Userprofile.js,user-Profile.js,userProfile.js are not
  • All new algorithms have a URL in their comments that points to Wikipedia or another similar explanation.
  • If this pull request resolves one or more open issues then the commit message containsFixes: #{$ISSUE_NO}.

@ahngeahnge changed the titlefeat: add mergeTwoSortedLinkedLIsts algorithmsfeat: add MergeTwoSortedLinkedLIsts algorithmsOct 5, 2023
@ahnge
Copy link
ContributorAuthor

I'm participating in hacktoberfest.

Copy link
Collaborator

@appgurueuappgurueu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

The class is unnecessary, this should be just the merge function.

(Note also that really, this "sorted merge" approach is more flexible: The proper abstraction is that of aniterator. This could then be aniterator merge taking two iterators and producing a merged one, which could be used to merge arrays, linked lists, doubly linked lists, whatever is iterable inorder and can be created inorder.)

ahngeand others added2 commitsOctober 10, 2023 09:08
change the function params and return value from Node to LinkedList.
@ahngeahnge requested a review fromappgurueuOctober 10, 2023 05:02
@raklaptudirmraklaptudirm merged commitca761d8 intoTheAlgorithms:masterOct 11, 2023
@ahnge
Copy link
ContributorAuthor

Could you please label this pr as hacktoberfest?

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@appgurueuappgurueuappgurueu approved these changes

@raklaptudirmraklaptudirmraklaptudirm approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

3 participants
@ahnge@appgurueu@raklaptudirm
[8]ページ先頭
©2009-2025 Movatter.jp