Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

feat: added Gray Code algorithm#1425

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
appgurueu merged 7 commits intoTheAlgorithms:masterfromHarshdev098:master
Oct 8, 2023

Conversation

Harshdev098
Copy link
Contributor

Open in Gitpod know more

Describe your change:

  • [Yes] Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

Checklist:

  • [Yes ] I have readCONTRIBUTING.md.
  • [Yes ] This pull request is all my own work -- I have not plagiarized.
  • [Yes ] I know that pull requests will not be merged if they fail the automated tests.
  • [Yes ] This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • [ Yes] All new JavaScript files are placed inside an existing directory.
  • [Yes ] All filenames should use the UpperCamelCase (PascalCase) style. There should be no spaces in filenames.
    Example:UserProfile.js is allowed butuserprofile.js,Userprofile.js,user-Profile.js,userProfile.js are not
  • All new algorithms have a URL in their comments that points to Wikipedia or another similar explanation.
  • If this pull request resolves one or more open issues then the commit message containsFixes: #{$ISSUE_NO}.

Copy link
Collaborator

@appgurueuappgurueu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

  • Use a JSDoc comment for the exported function
  • Inline the variables in your test, use binary number literals (0b...) to make the tests more understandable. Also, test more cases than just n=3 (for example the edge case n=0 is currently untested); you may want to useeach for this.

appgurueu
appgurueu previously approved these changesOct 4, 2023
Copy link
Member

@raklaptudirmraklaptudirm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Add some comments explaining the algorithm and adding some resources for further reading.

@appgurueuappgurueu merged commitf8ffacd intoTheAlgorithms:masterOct 8, 2023
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@appgurueuappgurueuappgurueu approved these changes

@raklaptudirmraklaptudirmraklaptudirm approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

3 participants
@Harshdev098@appgurueu@raklaptudirm
[8]ページ先頭
©2009-2025 Movatter.jp