Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

feat: Ciphers/MorseCode Algorithm#1315

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
raklaptudirm merged 18 commits intoTheAlgorithms:masterfrommrmagic2020:cipher_morse
May 1, 2023

Conversation

mrmagic2020
Copy link
Contributor

Open in Gitpod know more

Describe your change:

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

Checklist:

  • I have readCONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new JavaScript files are placed inside an existing directory.
  • All filenames should use the UpperCamelCase (PascalCase) style. There should be no spaces in filenames.
    Example:UserProfile.js is allowed butuserprofile.js,Userprofile.js,user-Profile.js,userProfile.js are not
  • All new algorithms have a URL in their comments that points to Wikipedia or another similar explanation.
  • If this pull request resolves one or more open issues then the commit message containsFixes: #{$ISSUE_NO}.

@mrmagic2020
Copy link
ContributorAuthor

probably ignore the style check of MorseCode.js, since I have to store the morse code with its corresponding string character; or there might be a better way to do this

@appgurueu
Copy link
Collaborator

probably ignore the style check of MorseCode.js, since I have to store the morse code with its corresponding string character; or there might be a better way to do this

It's telling you that there is no need to quote these properties. You should be able to safely remove the quotes. In the case of the digits this might indeed seem dubious, but I think it plays out fine because of JS's string coercion.

@mrmagic2020
Copy link
ContributorAuthor

probably ignore the style check of MorseCode.js, since I have to store the morse code with its corresponding string character; or there might be a better way to do this

It's telling you that there is no need to quote these properties. You should be able to safely remove the quotes. In the case of the digits this might indeed seem dubious, but I think it plays out fine because of JS's string coercion.

Yep! Tested the new code and it worked all the same.

@raklaptudirmraklaptudirm merged commit331a4d2 intoTheAlgorithms:masterMay 1, 2023
@mrmagic2020mrmagic2020 deleted the cipher_morse branchMay 1, 2023 10:00
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@appgurueuappgurueuappgurueu approved these changes

@raklaptudirmraklaptudirmraklaptudirm approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

3 participants
@mrmagic2020@appgurueu@raklaptudirm
[8]ページ先頭
©2009-2025 Movatter.jp