Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Added TopologicalSort implementaion on graph.#1311

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Open
bhaskarcsawant wants to merge4 commits intoTheAlgorithms:master
base:master
Choose a base branch
Loading
frombhaskarcsawant:topologicalSort

Conversation

bhaskarcsawant
Copy link

@bhaskarcsawantbhaskarcsawant commentedApr 2, 2023•
edited
Loading

Open in Gitpod know more

Describe your change:

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

Checklist:

  • I have readCONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new JavaScript files are placed inside an existing directory.
  • All filenames should use the UpperCamelCase (PascalCase) style. There should be no spaces in filenames.
    Example:UserProfile.js is allowed butuserprofile.js,Userprofile.js,user-Profile.js,userProfile.js are not
  • All new algorithms have a URL in their comments that points to Wikipedia or another similar explanation.
  • If this pull request resolves one or more open issues then the commit message containsFixes: #{$ISSUE_NO}.

Copy link
Collaborator

@appgurueuappgurueu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Still missing proper Jest tests.

visited[v] = true

// Recur for all the vertices adjacent to thisvertex
for (const i of this.adjacencyMap[v]) {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

I'd name thisv (orw to not shadow thev in scope) since this is a vertex, not an index. Perhaps better would beneighbor.

@appgurueu
Copy link
Collaborator

You misunderstood my comment: I wanted you to renamei tov,w orneighbor; I did not ask you to renamev toneighbor. This also isn't currently complying with the Standard code style (i.e. CI is still failing - in fact your changes to the existing codeundo the compliance).

@stale
Copy link

stalebot commentedJun 18, 2023

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stalestalebot added the staleClosed due to age labelJun 18, 2023
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@raklaptudirmraklaptudirmAwaiting requested review from raklaptudirmraklaptudirm is a code owner

@appgurueuappgurueuAwaiting requested review from appgurueuappgurueu is a code owner

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
staleClosed due to age
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

2 participants
@bhaskarcsawant@appgurueu
[8]ページ先頭
©2009-2025 Movatter.jp