NotificationsYou must be signed in to change notification settings
Fork5.7k
Star33.2k

algorithm: Hexagonal number#1265

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

raklaptudirm merged 3 commits intoTheAlgorithms:masterfromitsAkshayDubey:algorithm-hexagonal-number

Nov 30, 2022

Merged

algorithm: Hexagonal number#1265

raklaptudirm merged 3 commits intoTheAlgorithms:masterfromitsAkshayDubey:algorithm-hexagonal-number

Nov 30, 2022

Conversation

Copy link

Contributor

itsAkshayDubey commentedNov 25, 2022•
edited by gitpod-iobot
Loading

know more

Describe your change:

Add an algorithm?
Fix a bug or typo in an existing algorithm?
Documentation change?

Checklist:

I have readCONTRIBUTING.md.
This pull request is all my own work -- I have not plagiarized.
I know that pull requests will not be merged if they fail the automated tests.
This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
All new JavaScript files are placed inside an existing directory.
All filenames should use the UpperCamelCase (PascalCase) style. There should be no spaces in filenames.
Example:UserProfile.js is allowed butuserprofile.js,Userprofile.js,user-Profile.js,userProfile.js are not
All new algorithms have a URL in its comments that points to Wikipedia or other similar explanation.
If this pull request resolves one or more open issues then the commit message containsFixes: #{$ISSUE_NO}.

itsAkshayDubey added2 commits

November 25, 2022 10:55

feat: Add hexagonal number

b14b126

test: Add unit tests for hexagonal number

d006028

itsAkshayDubey requested review fromraklaptudirm andappgurueu ascode owners

November 25, 2022 05:27

refactor: Fix build failure

3b7b1f1

appgurueu approved these changes

Nov 25, 2022

View reviewed changes

Copy link

Collaborator

appgurueu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Looks fine, although just implementing such a formula is pretty trivial.

Copy link

Member

raklaptudirm commentedNov 26, 2022

@appgurueu Do you think it's too trivial and unremarkable to be merged?

Copy link

Collaborator

appgurueu commentedNov 26, 2022

@appgurueu Do you think it's too trivial and unremarkable to be merged?

Not sure. Thisdoes appear in some Project Euler problems and it is a well-known definition, so I say let's keep it (comparable to trivial math funcs like signum I'd say).