Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

chore: check for invalid input to factorial#1229

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
appgurueu merged 9 commits intoTheAlgorithms:masterfromabdullyahuza:master
Oct 27, 2022

Conversation

@abdullyahuza
Copy link
Contributor

@abdullyahuzaabdullyahuza commentedOct 26, 2022•
edited
Loading

Open in Gitpod know more

Describe your change:

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

Checklist:

  • I have readCONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new JavaScript files are placed inside an existing directory.
  • All filenames should use the UpperCamelCase (PascalCase) style. There should be no spaces in filenames.
    Example:UserProfile.js is allowed butuserprofile.js,Userprofile.js,user-Profile.js,userProfile.js are not
  • All new algorithms have a URL in its comments that points to Wikipedia or other similar explanation.
  • If this pull request resolves one or more open issues then the commit message containsFixes: #{$ISSUE_NO}.

Copy link
Member

@raklaptudirmraklaptudirm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Maybe add a check for negative numbers while you are at it?

appgurueu
appgurueu previously approved these changesOct 27, 2022
@abdullyahuza
Copy link
ContributorAuthor

All done.

@raklaptudirm
Copy link
Member

You don't seem to have removed thetypeof check, so do that.

@raklaptudirmraklaptudirm changed the titleAdd Invalid input to Factorialchore: check for invalid input to factorialOct 27, 2022
@appgurueuappgurueu merged commit5364a1c intoTheAlgorithms:masterOct 27, 2022
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@appgurueuappgurueuappgurueu approved these changes

@raklaptudirmraklaptudirmraklaptudirm approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@abdullyahuza@raklaptudirm@appgurueu
[8]ページ先頭
©2009-2025 Movatter.jp