NotificationsYou must be signed in to change notification settings
Fork5.8k
Star34k

added-ModularArithmetic-code#1217

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

raklaptudirm merged 3 commits intoTheAlgorithms:masterfromhiitesh1127:hiitesh1127-patch-5

Oct 20, 2022

Merged

added-ModularArithmetic-code#1217

raklaptudirm merged 3 commits intoTheAlgorithms:masterfromhiitesh1127:hiitesh1127-patch-5

Oct 20, 2022

Conversation

Copy link

Contributor

hiitesh1127 commentedOct 19, 2022•
edited by gitpod-iobot
Loading

know more

Describe your change:

Add an algorithm?
Fix a bug or typo in an existing algorithm?
Documentation change?
Other

Checklist:

I have readCONTRIBUTING.md.
This pull request is all my own work -- I have not plagiarized.
I know that pull requests will not be merged if they fail the automated tests.
This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
All new JavaScript files are placed inside an existing directory.
All filenames should use the UpperCamelCase (PascalCase) style. There should be no spaces in filenames.
Example:UserProfile.js is allowed butuserprofile.js,Userprofile.js,user-Profile.js,userProfile.js are not
All new algorithms have a URL in its comments that points to Wikipedia or other similar explanation.
If this pull request resolves one or more open issues then the commit message containsFixes: #{$ISSUE_NO}.

added-ModularArithmetic-code

7631836

hiitesh1127 requested review fromappgurueu andraklaptudirm ascode owners

October 19, 2022 17:04

fix-typo

2acead5

appgurueu requested changes

Oct 19, 2022

View reviewed changes

Copy link

Collaborator

appgurueu left a comment•
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

The modulus should not be hardcoded. Rather this should be a class (something like "ModRing"…) instantiated using the modulus (new ModRing(modulus)) providing the modular arithmetic operations as methods (ring.add(a, b)).

Alternatively you could consider a classModRingNumber with a constructor takingnum, mod params and the methods performing modular arithmetic after asserting that themods of the numbers match.