Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

algorithm: kosaraju#1215

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
raklaptudirm merged 5 commits intoTheAlgorithms:masterfromAdrito-M:Kosaraju
Oct 20, 2022
Merged

Conversation

@Adrito-M
Copy link
Contributor

@Adrito-MAdrito-M commentedOct 19, 2022•
edited by gitpod-iobot
Loading

Open in Gitpod know more

Describe your change:

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

Checklist:

  • I have readCONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new JavaScript files are placed inside an existing directory.
  • All filenames should use the UpperCamelCase (PascalCase) style. There should be no spaces in filenames.
    Example:UserProfile.js is allowed butuserprofile.js,Userprofile.js,user-Profile.js,userProfile.js are not
  • All new algorithms have a URL in its comments that points to Wikipedia or other similar explanation.
  • If this pull request resolves one or more open issues then the commit message containsFixes: #{$ISSUE_NO}.

@Adrito-M
Copy link
ContributorAuthor

@raklaptudirm@appgurueu This PR solves issue#1214

@Adrito-MAdrito-M mentioned this pull requestOct 19, 2022
@Adrito-M
Copy link
ContributorAuthor

Please Take A Look

appgurueu
appgurueu previously approved these changesOct 19, 2022
Copy link
Collaborator

@appgurueuappgurueu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Consider hiding the class as an implementation detail by only exporting a functionkosaraju(graph) (which uses the class).

@Adrito-M
Copy link
ContributorAuthor

@raklaptudirm please take a look

@raklaptudirmraklaptudirm changed the titlekosaraju and test addedalgorithm: kosarajuOct 20, 2022
@raklaptudirmraklaptudirm merged commitce9e294 intoTheAlgorithms:masterOct 20, 2022
@Adrito-MAdrito-M deleted the Kosaraju branchOctober 20, 2022 17:51
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@appgurueuappgurueuappgurueu approved these changes

@raklaptudirmraklaptudirmraklaptudirm approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Adrito-M@appgurueu@raklaptudirm
[8]ページ先頭
©2009-2025 Movatter.jp