Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork5.7k
docs: improve the PR template#1213
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Open
Panquesito7 wants to merge3 commits intomasterChoose a base branch fromimprove_pr_template
base:master
Could not load branches
Branch not found:{{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline, and old review comments may become outdated.
Uh oh!
There was an error while loading.Please reload this page.
Open
Changes fromall commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Uh oh!
There was an error while loading.Please reload this page.
Jump to
Jump to file
Failed to load files.
Loading
Uh oh!
There was an error while loading.Please reload this page.
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,19 +1,26 @@ | ||
### Describe your change | ||
- [ ] Add an algorithm? | ||
- [ ] Fix a bug or typo in an existing algorithm? | ||
- [ ] Documentation change? | ||
- [ ] Miscellaneous changes? <!-- Please explain your changes below. See the following example. --> | ||
<!-- Remove the issue number section if applicable. | ||
- Fix the `DIRECTORY.md` workflow from not committing changes. | ||
- Closes #{$ISSUE_NO} | ||
--> | ||
<!-- | ||
### Checklist | ||
- [ ] I have read [CONTRIBUTING.md](https://github.com/TheAlgorithms/JavaScript/blob/master/CONTRIBUTING.md). | ||
- [ ] This pull request is all my own work -- I have not plagiarized. | ||
- [ ] I know that pull requests will not be merged if they fail the automated tests. | ||
- [ ] This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms. | ||
- [ ] All new JavaScript files are placed inside an existing directory. | ||
- [ ] All filenames should use the UpperCamelCase (PascalCase) style. There should be no spaces in filenames. | ||
- **Example:** `UserProfile.js` is allowed but `userprofile.js`, `Userprofile.js`, `user-Profile.js`, and `userProfile.js` are not. | ||
- [ ] All new algorithms have a URL in their comments that points to Wikipedia or similar explanations. | ||
- [ ] If this pull request resolves one or more open issues, add `Closes: #{$ISSUE_NO}` to this PR. | ||
--> |
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.