Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

docs: improve the PR template#1213

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Open
Panquesito7 wants to merge3 commits intomaster
base:master
Choose a base branch
Loading
fromimprove_pr_template

Conversation

@Panquesito7
Copy link
Member

Describe your change

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?
  • Miscellaneous changes?

Checklist

  • I have readCONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new JavaScript files are placed inside an existing directory.
  • All filenames should use the UpperCamelCase (PascalCase) style. There should be no spaces in filenames.
    • Example:UserProfile.js is allowed butuserprofile.js,Userprofile.js,user-Profile.js, anduserProfile.js are not.
  • All new algorithms have a URL in their comments that points to Wikipedia or similar explanations.
  • If this pull request resolves one or more open issues, addCloses: #{$ISSUE_NO} to this PR.

@Panquesito7Panquesito7 added the documentationPR that adds or fixes docs; issue that points out issues with the docs labelOct 19, 2022
Copy link
Collaborator

@appgurueuappgurueu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

I'd prefer it if we could simplify the PR template rather than complicating it further…

@Panquesito7
Copy link
MemberAuthor

I'd prefer it if we could simplify the PR template rather than complicating it further…

What do you suggest/think we should do?

@appgurueu
Copy link
Collaborator

I'd prefer it if we could simplify the PR template rather than complicating it further…

What do you suggest/think we should do?

Perhaps get rid of the checklist? It adds no value for reviewers; it should be "private" to the PR author.

Panquesito7 reacted with thumbs up emoji

@stale
Copy link

stalebot commentedJun 18, 2023

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stalestalebot added the staleClosed due to age labelJun 18, 2023
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@raklaptudirmraklaptudirmAwaiting requested review from raklaptudirmraklaptudirm is a code owner

@appgurueuappgurueuAwaiting requested review from appgurueuappgurueu is a code owner

At least 2 approving reviews are required to merge this pull request.

Assignees

No one assigned

Labels

documentationPR that adds or fixes docs; issue that points out issues with the docsstaleClosed due to age

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Panquesito7@appgurueu
[8]ページ先頭
©2009-2025 Movatter.jp