Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

feat: run CI on all branches and PRs#1212

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Closed
Panquesito7 wants to merge1 commit intomasterfromworkflow_prs
Closed

Conversation

Panquesito7
Copy link
Member

@Panquesito7Panquesito7 commentedOct 19, 2022•
edited by gitpod-iobot
Loading

Open in Gitpod know more

Describe your change:

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?
  • Other

Checklist:

  • I have readCONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new JavaScript files are placed inside an existing directory.
  • All filenames should use the UpperCamelCase (PascalCase) style. There should be no spaces in filenames.
    Example:UserProfile.js is allowed butuserprofile.js,Userprofile.js,user-Profile.js,userProfile.js are not
  • All new algorithms have a URL in its comments that points to Wikipedia or other similar explanation.
  • If this pull request resolves one or more open issues then the commit message containsFixes: #{$ISSUE_NO}.

@Panquesito7Panquesito7 added the choreGeneral improvement labelOct 19, 2022
@Panquesito7
Copy link
MemberAuthor

Strange. Seems theCode style and tests part takes too long to run. 👀

@raklaptudirm
Copy link
Member

Strange. Seems theCode style and tests part takes too long to run. 👀

Thats why we run the full tests only on master. Closing because this is the correct functionality.

Panquesito7 reacted with thumbs up emoji

@Panquesito7Panquesito7 deleted the workflow_prs branchNovember 4, 2022 21:44
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@raklaptudirmraklaptudirmAwaiting requested review from raklaptudirmraklaptudirm is a code owner

@appgurueuappgurueuAwaiting requested review from appgurueuappgurueu is a code owner

Assignees
No one assigned
Labels
choreGeneral improvement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

2 participants
@Panquesito7@raklaptudirm
[8]ページ先頭
©2009-2025 Movatter.jp