Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Adding new issue template#1206

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
Panquesito7 merged 12 commits intoTheAlgorithms:masterfromzendranm:add-issue-template
Nov 6, 2022
Merged

Adding new issue template#1206

Panquesito7 merged 12 commits intoTheAlgorithms:masterfromzendranm:add-issue-template
Nov 6, 2022

Conversation

zendranm
Copy link
Contributor

@zendranmzendranm commentedOct 18, 2022•
edited
Loading

Open in Gitpod know more

Solves issue#1204

Describe your change:

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

Checklist:

  • I have readCONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new JavaScript files are placed inside an existing directory.
  • All filenames should use the UpperCamelCase (PascalCase) style. There should be no spaces in filenames.
    Example:UserProfile.js is allowed butuserprofile.js,Userprofile.js,user-Profile.js,userProfile.js are not
  • All new algorithms have a URL in its comments that points to Wikipedia or other similar explanation.
  • If this pull request resolves one or more open issues then the commit message containsFixes: #{$ISSUE_NO}.

@zendranmzendranm marked this pull request as ready for reviewOctober 18, 2022 15:17
@zendranmzendranm mentioned this pull requestOct 18, 2022
Copy link
Collaborator

@appgurueuappgurueu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

The feature request template is not really applicable; algorithms are not to be requested (rather, PRs should be opened directly). The bug template should probably have a "bug" label. Hints to the one opening the issue such as "Before you open an issue ..." should be comments.

zendranm reacted with thumbs up emoji
@Panquesito7
Copy link
Member

The feature request template is not really applicable...

I still think we should keep the feature request template. For example: what if I want to add a new workflow or functionality and make an issue before making any PRs?
@raklaptudirm, what do you think about this?

@Panquesito7Panquesito7 added the documentationPR that adds or fixes docs; issue that points out issues with the docs labelOct 18, 2022
@Panquesito7Panquesito7 linked an issueOct 18, 2022 that may beclosed by this pull request
@raklaptudirm
Copy link
Member

The feature request template is not really applicable...

I still think we should keep the feature request template. For example: what if I want to add a new workflow or functionality and make an issue before making any PRs?

@raklaptudirm, what do you think about this?

We should explicitly mention in the issue template that it is not for requesting algorithms imo.

zendranm and Panquesito7 reacted with thumbs up emoji

@zendranmzendranm requested review fromPanquesito7 andappgurueu and removed request forappgurueu andPanquesito7October 21, 2022 11:23
Copy link
Member

@Panquesito7Panquesito7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Wrong indentation.

Panquesito7
Panquesito7 previously approved these changesOct 28, 2022
Copy link
Member

@Panquesito7Panquesito7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Looks great. Thanks! 🚀

@zendranm
Copy link
ContributorAuthor

zendranm commentedOct 28, 2022•
edited
Loading

@Panquesito7@appgurueu Since there is not much time until the end of the Hactoberfest, would you mind adding thehacktoberfest-accepted label to this PR? I will add any required code-review changes once I get aresponse here.

Panquesito7 reacted with thumbs up emoji

@appgurueuappgurueu added the hacktoberfest-acceptedAccepted to be counted towards Hacktoberfest labelOct 28, 2022
Copy link
Member

@Panquesito7Panquesito7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Great, thanks! 🚀

@Panquesito7Panquesito7 merged commit9d4adbb intoTheAlgorithms:masterNov 6, 2022
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@appgurueuappgurueuappgurueu approved these changes

@Panquesito7Panquesito7Panquesito7 approved these changes

@raklaptudirmraklaptudirmAwaiting requested review from raklaptudirmraklaptudirm is a code owner

Assignees
No one assigned
Labels
documentationPR that adds or fixes docs; issue that points out issues with the docshacktoberfest-acceptedAccepted to be counted towards Hacktoberfest
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[DOCS] Add issue templates
4 participants
@zendranm@Panquesito7@raklaptudirm@appgurueu
[8]ページ先頭
©2009-2025 Movatter.jp