NotificationsYou must be signed in to change notification settings
Fork5.7k
Star33.3k

Updates Discord Invite Link#1202

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

appgurueu merged 4 commits intoTheAlgorithms:masterfromzafar-hussain:master

Oct 17, 2022

Merged

Updates Discord Invite Link#1202

appgurueu merged 4 commits intoTheAlgorithms:masterfromzafar-hussain:master

Oct 17, 2022

Conversation

Copy link

Contributor

zafar-hussain commentedOct 17, 2022

know more

Describe your change:

Add an algorithm?
Fix a bug or typo in an existing algorithm?
Documentation change?

Checklist:

I have readCONTRIBUTING.md.
This pull request is all my own work -- I have not plagiarized.
I know that pull requests will not be merged if they fail the automated tests.
This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
All new JavaScript files are placed inside an existing directory.
All filenames should use the UpperCamelCase (PascalCase) style. There should be no spaces in filenames.
Example:UserProfile.js is allowed butuserprofile.js,Userprofile.js,user-Profile.js,userProfile.js are not
All new algorithms have a URL in its comments that points to Wikipedia or other similar explanation.
If this pull request resolves one or more open issues then the commit message containsFixes: #{$ISSUE_NO}.

A discord link in Readme.md was updated to the new link to discord invites, namely "https://the-algorithms.com/discord/"

Updates Discord Invite Link

6078be2

zafar-hussain requested review fromraklaptudirm andappgurueu ascode owners

October 17, 2022 10:32

Copy link

ContributorAuthor

zafar-hussain commentedOct 17, 2022

@reviewers

please, if you can add "hacktoberfest-accepted" label, if this PR is fulfilled

cheers

appgurueu reviewed

Oct 17, 2022

View reviewed changes

README.md OutdatedShow resolvedHide resolved

Copy link

Collaborator

appgurueu commentedOct 17, 2022

@reviewers
please, if you can add "hacktoberfest-accepted" label, if this PR is fulfilled
cheers

I'm afraid this PR is probably too trivial to be accepted (I'm also wary of using the TheAlgorithms link rather than a direct link to the Discord).

zafar-hussain commented

Oct 17, 2022

View reviewed changes

Copy link

ContributorAuthor

zafar-hussain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Should I change the link back to the original, or leave it as it is?

Sorry for a newbie question by me

cheers

Copy link

Collaborator

appgurueu commentedOct 17, 2022•
edited
Loading

Should I change the link back to the original, or leave it as it is?

Changing it back would render this PR detrimental. I'm trying to determine whether we should close the PR.@raklaptudirm

@Panquesito7 would probably want the link to be updated (possible rationale: ability to use a redirect and change the underlying link, hopefully no tracking intended).