Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

algorithm: SegmentTree#1178

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged

Conversation

changicho
Copy link
Contributor

@changichochangicho commentedOct 13, 2022•
edited
Loading

Open in Gitpod know more

Describe your change:

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

Checklist:

  • I have readCONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new JavaScript files are placed inside an existing directory.
  • All filenames should use the UpperCamelCase (PascalCase) style. There should be no spaces in filenames.
    Example:UserProfile.js is allowed butuserprofile.js,Userprofile.js,user-Profile.js,userProfile.js are not
  • All new algorithms have a URL in its comments that points to Wikipedia or other similar explanation.
  • If this pull request resolves one or more open issues then the commit message containsFixes: #{$ISSUE_NO}.

Copy link
Collaborator

@appgurueuappgurueu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Elegant & clever implementation. Can you try to add more comments?

changicho reacted with eyes emoji
@changicho
Copy link
ContributorAuthor

Elegant & clever implementation. Can you try to add more comments?

Sure! I add comments in new commit. Please check. Thanks.

@appgurueu
Copy link
Collaborator

appgurueu commentedOct 14, 2022•
edited
Loading

I was thinking of comments on the implementation details (e.g. how you store the binary tree in a list (same trick as heaps often use), how to calc. the parent pos. from a child pos. and vice versa).

changicho reacted with eyes emoji

@changicho
Copy link
ContributorAuthor

I was thinking of comments on the implementation details (e.g. how you store the binary tree in a list (same trick as heaps often use), how to calc. the parent pos. from a child pos. and vice versa).

I add comments on the implementation details in new commit!

appgurueu
appgurueu previously approved these changesOct 14, 2022
it duplicated by next line. so it is not necessary
@changichochangicho changed the titleCreate SegmentTreealgorithm: SegmentTreeOct 15, 2022
@changicho
Copy link
ContributorAuthor

@raklaptudirm Could you review this PR? 🙏

@raklaptudirmraklaptudirm merged commit5867186 intoTheAlgorithms:masterOct 20, 2022
@changichochangicho deleted the feature/segment-tree branchOctober 21, 2022 08:07
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@appgurueuappgurueuappgurueu approved these changes

@raklaptudirmraklaptudirmraklaptudirm approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

3 participants
@changicho@appgurueu@raklaptudirm
[8]ページ先頭
©2009-2025 Movatter.jp