Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

solution: Project Euler Problem 19#1174

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Open
MatheusMuriel wants to merge6 commits intoTheAlgorithms:master
base:master
Choose a base branch
Loading
fromMatheusMuriel:ProjectEuler019

Conversation

@MatheusMuriel
Copy link
Contributor

Open in Gitpod know more

Describe your change:

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

Checklist:

  • I have readCONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new JavaScript files are placed inside an existing directory.
  • All filenames should use the UpperCamelCase (PascalCase) style. There should be no spaces in filenames.
    Example:UserProfile.js is allowed butuserprofile.js,Userprofile.js,user-Profile.js,userProfile.js are not
  • All new algorithms have a URL in its comments that points to Wikipedia or other similar explanation.
  • If this pull request resolves one or more open issues then the commit message containsFixes: #{$ISSUE_NO}.

Copy link
Collaborator

@appgurueuappgurueu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Looks good, but please add some comments.

@MatheusMuriel
Copy link
ContributorAuthor

Added the comments and refactored to make more legible

Copy link
Collaborator

@appgurueuappgurueu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Turning the terse leap year condition into anif-else construction that takes about twenty times as much vertical space (!) is pretty bad. If anything, the current construction should be made to use a ternary rather than relying on coercion from bool to 0 or 1.

The rename ofn tonumberOfSundays does indeed improve readability though.

Copy link
ContributorAuthor

@MatheusMurielMatheusMuriel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Changed to a ternary if

@MatheusMuriel
Copy link
ContributorAuthor

offtopic:@appgurueu i saw that you like Lua, a professor at my university studied in the department that developed the Lua language at PUC-Rio 😄

appgurueu
appgurueu previously approved these changesOct 24, 2022
@raklaptudirmraklaptudirm changed the titleIncluded Project Euler 19 solutionsolution: Project Euler Problem 19Oct 25, 2022
raklaptudirm
raklaptudirm previously approved these changesOct 25, 2022
@appgurueu
Copy link
Collaborator

offtopic:@appgurueu i saw that you like Lua, a professor at my university studied in the department that developed the Lua language at PUC-Rio smile

Oh that's nice!

@appgurueuappgurueu dismissed stale reviews fromraklaptudirm and themself viab5cfb1eOctober 25, 2022 09:27
@stale
Copy link

stalebot commentedJun 18, 2023

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stalestalebot added the staleClosed due to age labelJun 18, 2023
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@appgurueuappgurueuappgurueu approved these changes

@raklaptudirmraklaptudirmraklaptudirm left review comments

At least 2 approving reviews are required to merge this pull request.

Assignees

No one assigned

Labels

staleClosed due to age

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@MatheusMuriel@appgurueu@raklaptudirm
[8]ページ先頭
©2009-2025 Movatter.jp