NotificationsYou must be signed in to change notification settings
Fork5.7k
Star33.2k

Contribute: Added algorithm and tests for Unique Paths DP problem#1118

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Open

Jaiharishan wants to merge6 commits intoTheAlgorithms:master

base:master

Choose a base branch

fromJaiharishan:master

Open

Contribute: Added algorithm and tests for Unique Paths DP problem#1118

Jaiharishan wants to merge6 commits intoTheAlgorithms:masterfromJaiharishan:master

Conversation

Copy link

Jaiharishan commentedOct 3, 2022

know more

Describe your change:

Add an algorithm?
Fix a bug or typo in an existing algorithm?
Documentation change?

Checklist:

I have readCONTRIBUTING.md.
This pull request is all my own work -- I have not plagiarized.
I know that pull requests will not be merged if they fail the automated tests.
This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
All new JavaScript files are placed inside an existing directory.
All filenames should use the UpperCamelCase (PascalCase) style. There should be no spaces in filenames.
Example:UserProfile.js is allowed butuserprofile.js,Userprofile.js,user-Profile.js,userProfile.js are not
All new algorithms have a URL in its comments that points to Wikipedia or other similar explanation.
If this pull request resolves one or more open issues then the commit message containsFixes: #{$ISSUE_NO}.

Contribute: Added algorithm for Unique Paths problem

781a7cf

Jaiharishan requested review fromraklaptudirm andappgurueu ascode owners

October 3, 2022 13:08

raklaptudirm requested changes

Oct 3, 2022

View reviewed changes

Copy link

Member

raklaptudirm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Do not edit thepackage-lock.json

Copy link

Author

Jaiharishan commentedOct 3, 2022

Do not edit thepackage-lock.json

Will revert back to the previous one. Is it fine?

Fix: Fixed Package conflicts

cb8b0e1

Copy link

Author

Jaiharishan commentedOct 3, 2022

@raklaptudirm I have made the changes you told. Check if its fine now.

appgurueu reviewed

Oct 3, 2022

View reviewed changes

Dynamic-Programming/tests/UniquePaths.test.js OutdatedShow resolvedHide resolved

Jaiharishan added2 commits

October 3, 2022 20:51

Fix: Names for test cases are changed

0496b33

Fix: Made all test cases to go under single block

b721d48

appgurueu reviewed

Oct 3, 2022

View reviewed changes

Dynamic-Programming/tests/UniquePaths.test.js OutdatedShow resolvedHide resolved

Fix: Made the test cases to come under single Test block

e1c8bd1

Copy link

Author

Jaiharishan commentedOct 3, 2022•
edited
Loading

I have made all cases to some under single test block as you said.

Copy link

Author

Jaiharishan commentedOct 3, 2022

Is this fine now?

appgurueu previously approved these changes

Oct 3, 2022

View reviewed changes

appgurueu added the algorithmAdds or improves an algorithm label

Oct 3, 2022

raklaptudirm requested changes

Oct 3, 2022

View reviewed changes

Copy link

Member

raklaptudirm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Add some more comments in your code, it can be hard to understand for someone trying to learn.

Copy link

Author

Jaiharishan commentedOct 3, 2022 via email

Sure sir

…

On Mon, 3 Oct 2022, 22:37 Rak Laptudirm, ***@***.***> wrote: ***@***.**** requested changes on this pull request. Add some more comments in your code, it can be hard to understand for someone trying to learn. — Reply to this email directly, view it on GitHub <#1118 (review)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ASZ5DP2HHTH6VBQDHEFT4NLWBMHGVANCNFSM6AAAAAAQ3SRWZQ> . You are receiving this because you authored the thread.Message ID: ***@***.***>

Improve: More comments added for better understanding

3dac5aa

Jaiharishan dismissedappgurueu’sstale review via3dac5aa

October 4, 2022 03:58

Copy link

Author

Jaiharishan commentedOct 4, 2022

I have added comments, is it ok now?

Copy link

Author

Jaiharishan commentedOct 5, 2022

Do I need to change anything sir?

raklaptudirm requested changes

Oct 5, 2022

View reviewed changes

Copy link

Member

raklaptudirm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

You should add a short explanation of how the algorithm works.

Copy link

Author

Jaiharishan commentedOct 5, 2022 via email

Will add a explanation then

…

On Thu, 6 Oct 2022, 00:41 Rak Laptudirm, ***@***.***> wrote: ***@***.**** requested changes on this pull request. You should add a short explanation of how the algorithm works. — Reply to this email directly, view it on GitHub <#1118 (review)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ASZ5DPYJ3RIRY2IA4JXLJWLWBXHHTANCNFSM6AAAAAAQ3SRWZQ> . You are receiving this because you authored the thread.Message ID: ***@***.***>

Copy link

stalebot commentedNov 2, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.