Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

algorithm: find the middle of linked-list#1096

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
raklaptudirm merged 5 commits intoTheAlgorithms:masterfrom10kartik:develop
Sep 10, 2022

Conversation

10kartik
Copy link
Contributor

@10kartik10kartik commentedSep 8, 2022•
edited
Loading

Open in Gitpod know more

Describe your change:

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

Checklist:

  • I have readCONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new JavaScript files are placed inside an existing directory.
  • All filenames should use the UpperCamelCase (PascalCase) style. There should be no spaces in filenames.
    Example:UserProfile.js is allowed butuserprofile.js,Userprofile.js,user-Profile.js,userProfile.js are not

nuhmanpk
nuhmanpk previously approved these changesSep 8, 2022
Copy link
Collaborator

@appgurueuappgurueu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

This is not the form we expect algorithms to be in. Please:

  • Add comments;
  • Make this a re-usable and exported function;
  • Add tests

10kartik reacted with thumbs up emoji
@10kartik
Copy link
ContributorAuthor

Hello@appgurueu, I hope the algorithm is now as expected:

  • Reusable and exported function solution
  • Added tests
  • Changed comments

Please review and suggest changes, if any.
Thanks!

10kartik reacted with eyes emoji

Copy link
Collaborator

@appgurueuappgurueu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

There's no need for a class here; this should be a single function or a method of a linked list class (if there is a suitable one).

10kartik reacted with thumbs up emoji
@10kartik
Copy link
ContributorAuthor

Hey@appgurueu, Adding a method in the existing LinkedList class made more sense.
Please review and suggest changes, if any.
Thanks!

@appgurueuappgurueu added the algorithmAdds or improves an algorithm labelSep 9, 2022
@raklaptudirmraklaptudirm changed the titleAdded Middle of linked-list implementation.algorithm: find the middle of linked-listSep 10, 2022
@raklaptudirmraklaptudirm merged commit6ad2467 intoTheAlgorithms:masterSep 10, 2022
@10kartik10kartik deleted the develop branchSeptember 14, 2022 14:38
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@appgurueuappgurueuappgurueu approved these changes

@raklaptudirmraklaptudirmraklaptudirm approved these changes

@nuhmanpknuhmanpknuhmanpk left review comments

Assignees
No one assigned
Labels
algorithmAdds or improves an algorithm
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Find Middle Node of linked list functoin implementation not there
4 participants
@10kartik@appgurueu@nuhmanpk@raklaptudirm
[8]ページ先頭
©2009-2025 Movatter.jp