Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

add: countSubstrings function implementation#1091

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
raklaptudirm merged 3 commits intoTheAlgorithms:masterfromajinkyac03:develop
Sep 7, 2022

Conversation

ajinkyac03
Copy link
Contributor

Open in Gitpod know more

Describe your change:

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

Checklist:

  • I have readCONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new JavaScript files are placed inside an existing directory.
  • All filenames should use the UpperCamelCase (PascalCase) style. There should be no spaces in filenames.
    Example:UserProfile.js is allowed butuserprofile.js,Userprofile.js,user-Profile.js,userProfile.js are not

Fixes#1090

Copy link
Collaborator

@appgurueuappgurueu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

What about overlapping substrings? I might expectcountSubstrings("aaa", "aa") to be2. Currently this is undocumented & untested behavior.

Copy link
Collaborator

@appgurueuappgurueu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Note: Runtime is O(n²) due to the naive implementation.

@appgurueuappgurueu added the algorithmAdds or improves an algorithm labelSep 6, 2022
@raklaptudirmraklaptudirm changed the titleAdded countSubstrings function implementation.add: countSubstrings function implementation.Sep 7, 2022
@raklaptudirmraklaptudirm changed the titleadd: countSubstrings function implementation.add: countSubstrings function implementationSep 7, 2022
@raklaptudirmraklaptudirm merged commit6c718c0 intoTheAlgorithms:masterSep 7, 2022
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@appgurueuappgurueuappgurueu approved these changes

@raklaptudirmraklaptudirmraklaptudirm approved these changes

Assignees
No one assigned
Labels
algorithmAdds or improves an algorithm
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Count occurrences of substring in a string function implementation not there
3 participants
@ajinkyac03@appgurueu@raklaptudirm
[8]ページ先頭
©2009-2025 Movatter.jp