Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Fibonacci.js overhaul#1049

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
raklaptudirm merged 25 commits intoTheAlgorithms:masterfromRudxain:patch-2
Jun 27, 2022
Merged

Fibonacci.js overhaul#1049

raklaptudirm merged 25 commits intoTheAlgorithms:masterfromRudxain:patch-2
Jun 27, 2022

Conversation

Rudxain
Copy link
Contributor

@RudxainRudxain commentedJun 21, 2022•
edited
Loading

AddedBigInt support toFibonacciMatrixExpo,Identity,matrixMultiply, andmatrixExpo. And added the extension to negative domain for all fns in that file. And added agenerator function example. Also corrected indices to return 0 if the input arg is 0 (because that's the 0th Fib).
Fixes:#1047

Open in Gitpod know more

Describe your change:

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

Checklist:

  • I have readCONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new JavaScript files are placed inside an existing directory.
  • All filenames should use the UpperCamelCase (PascalCase) style. There should be no spaces in filenames.
    Example:UserProfile.js is allowed butuserprofile.js,Userprofile.js,user-Profile.js,userProfile.js are not
  • All new algorithms have a URL in its comments that points to Wikipedia or other similar explanation.
  • If this pull request resolves one or more open issues then the commit message containsFixes: #{$ISSUE_NO}.

Also added support to `Identity`, `matrixMultiply`, and `matrixExpo`
@appgurueuappgurueu added featureAdds a new feature algorithmAdds or improves an algorithm labelsJun 21, 2022
@lgtm-com
Copy link

This pull requestintroduces 1 alert when merging33df079 into95a8ec0 -view on LGTM.com

new alerts:

  • 1 for Useless comparison test

@lgtm-com
Copy link

This pull requestintroduces 1 alert when mergingf4f1d53 into95a8ec0 -view on LGTM.com

new alerts:

  • 1 for Useless comparison test

@lgtm-com
Copy link

This pull requestintroduces 1 alert when merging2bcbc58 into95a8ec0 -view on LGTM.com

new alerts:

  • 1 for Useless comparison test

@lgtm-com
Copy link

This pull requestintroduces 1 alert when merging3d865f3 into95a8ec0 -view on LGTM.com

new alerts:

  • 1 for Useless comparison test

@lgtm-com
Copy link

This pull requestintroduces 1 alert when merging0dc81a8 into95a8ec0 -view on LGTM.com

new alerts:

  • 1 for Useless comparison test

@lgtm-com
Copy link

This pull requestintroduces 1 alert when merging1f61f51 into95a8ec0 -view on LGTM.com

new alerts:

  • 1 for Useless comparison test

@RudxainRudxain changed the titleAdded BigInt support toFibonacciMatrixExpoAdd BigInt support toFibonacciMatrixExpo and negatives for the entire Fibonacci.jsJun 21, 2022
@RudxainRudxain changed the titleAdd BigInt support toFibonacciMatrixExpo and negatives for the entire Fibonacci.jsAddBigInt & negative support toFibonacci.jsJun 21, 2022
@lgtm-com
Copy link

This pull requestintroduces 1 alert when mergingb2101fc into95a8ec0 -view on LGTM.com

new alerts:

  • 1 for Useless comparison test

@lgtm-com
Copy link

This pull requestintroduces 1 alert when mergingc5fe0b5 into95a8ec0 -view on LGTM.com

new alerts:

  • 1 for Useless comparison test

This wasn't originally part of the PR, but I thought it would be good to add
@lgtm-com
Copy link

This pull requestintroduces 3 alerts when merging787fd75 into95a8ec0 -view on LGTM.com

new alerts:

  • 1 for Expression has no effect
  • 1 for Assignment to property of primitive value
  • 1 for Useless comparison test

@RudxainRudxain changed the titleAddBigInt & negative support toFibonacci.jsAddBigInt & negative support toFibonacci.js, also generator fnJun 21, 2022
@lgtm-com
Copy link

This pull requestintroduces 3 alerts when merging028ebe9 into95a8ec0 -view on LGTM.com

new alerts:

  • 1 for Expression has no effect
  • 1 for Assignment to property of primitive value
  • 1 for Useless comparison test

@RudxainRudxain changed the titleAddBigInt & negative support toFibonacci.js, also generator fnFibonacci.js overhaulJun 21, 2022
@lgtm-com
Copy link

This pull requestintroduces 3 alerts when merging69bbe51 into95a8ec0 -view on LGTM.com

new alerts:

  • 1 for Expression has no effect
  • 1 for Assignment to property of primitive value
  • 1 for Useless comparison test

@Rudxain
Copy link
ContributorAuthor

Rudxain commentedJun 21, 2022•
edited
Loading

  • 1 for Assignment to property of primitive value

lol, the bot can't recognize the destructuring assignment syntax

My bad, I didn't recognize that the array literal was interpreted as subscript, lol

Rudxain reacted with laugh emoji

@lgtm-com
Copy link

This pull requestintroduces 3 alerts when merging82861ef into95a8ec0 -view on LGTM.com

new alerts:

  • 1 for Expression has no effect
  • 1 for Assignment to property of primitive value
  • 1 for Useless comparison test

@Rudxain
Copy link
ContributorAuthor

Rudxain commentedJun 21, 2022•
edited
Loading

I tried removing the trailing whitespace, but somehow I can't find them. It seems those are control chars.
Update: Not even VScode can find them. I activated control char rendering and whitespace rendering, no results. I clicked the "Remove all trailing whitespace" option, but absolutely nothing changed. This seems to be a bug

@RudxainRudxain marked this pull request as ready for reviewJune 21, 2022 20:37
@raklaptudirm
Copy link
Member

Usestandard.js to style your code and remove trailing whitespace. Make sure to readCONTRIBUTING.md before making any contributions.

@raklaptudirmraklaptudirm added the code style issueFailing style checks labelJun 22, 2022
@Rudxain
Copy link
ContributorAuthor

Make sure to readCONTRIBUTING.md

I already did it, many times, and thoroughly. I just prefer to fix style errors manually. But it seems the only solution now is to use SJS. I'll install NPM & Node now

@Rudxain
Copy link
ContributorAuthor

Wait, now I read the problem is inFibonacci.test.js, notFibonacci.js 🤦‍♂️. Fixing now

raklaptudirm reacted with thumbs up emoji

@raklaptudirmraklaptudirm removed the code style issueFailing style checks labelJun 22, 2022
raklaptudirm
raklaptudirm previously approved these changesJun 26, 2022
appgurueu
appgurueu previously approved these changesJun 26, 2022
Copy link
Collaborator

@appgurueuappgurueu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Definitely a significant improvement. I've got some minor comments regarding consistency.

Rudxain reacted with thumbs up emoji
@RudxainRudxain dismissed stale reviews fromappgurueu andraklaptudirm via21ff3fdJune 26, 2022 18:01
@raklaptudirmraklaptudirm merged commit1b64ba6 intoTheAlgorithms:masterJun 27, 2022
@RudxainRudxain deleted the patch-2 branchJune 27, 2022 04:43
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@appgurueuappgurueuappgurueu approved these changes

@raklaptudirmraklaptudirmraklaptudirm approved these changes

Assignees
No one assigned
Labels
algorithmAdds or improves an algorithmfeatureAdds a new feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fibonacci Matrix doesn't useBigInts
3 participants
@Rudxain@raklaptudirm@appgurueu
[8]ページ先頭
©2009-2025 Movatter.jp