Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

More accurate error message atIsDivisible#1048

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
raklaptudirm merged 2 commits intoTheAlgorithms:masterfromRudxain:patch-1
Jun 21, 2022
Merged

More accurate error message atIsDivisible#1048

raklaptudirm merged 2 commits intoTheAlgorithms:masterfromRudxain:patch-1
Jun 21, 2022

Conversation

Rudxain
Copy link
Contributor

@RudxainRudxain commentedJun 20, 2022•
edited
Loading

Open in Gitpod know more

Describe your change:

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

This PR edits the error message in that file (Maths/IsDivisible.js) to be more accurate to its context. BecauseInfinity andNaN aren't valid Real numbers.

Checklist:

  • I have readCONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new JavaScript files are placed inside an existing directory.
  • All filenames should use the UpperCamelCase (PascalCase) style. There should be no spaces in filenames.
    Example:UserProfile.js is allowed butuserprofile.js,Userprofile.js,user-Profile.js,userProfile.js are not
  • All new algorithms have a URL in its comments that points to Wikipedia or other similar explanation.
  • If this pull request resolves one or more open issues then the commit message containsFixes: #{$ISSUE_NO}.

@appgurueuappgurueu added the code qualityCode quality improvement labelJun 21, 2022
appgurueu
appgurueu previously approved these changesJun 21, 2022
Copy link
Collaborator

@appgurueuappgurueu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

(consider lowercasing ther fromreal)

@Rudxain
Copy link
ContributorAuthor

(consider lowercasing ther fromreal)

Why? I thought it was a good idea to make it uppercase to distinguish between "real" (reality) and "Real" (the set of all non-complex rational and irrational numbers). But, for consistency, it may also be a good idea to lowercase it

@appgurueu
Copy link
Collaborator

Why? I thought it was a good idea to make it uppercase to distinguish between "real" (reality) and "Real" (the set of all non-complex rational and irrational numbers). But, for consistency, it may also be a good idea to lowercase it

"real number" already is an unambiguous term and thus fine - no need to bend the rules of capitalization to emphasize the "real" property.

@Rudxain
Copy link
ContributorAuthor

Ok then I'll change it now

@raklaptudirmraklaptudirm merged commit95a8ec0 intoTheAlgorithms:masterJun 21, 2022
@RudxainRudxain deleted the patch-1 branchJune 21, 2022 17:40
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@appgurueuappgurueuappgurueu approved these changes

@raklaptudirmraklaptudirmraklaptudirm approved these changes

Assignees
No one assigned
Labels
code qualityCode quality improvement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

3 participants
@Rudxain@appgurueu@raklaptudirm
[8]ページ先頭
©2009-2025 Movatter.jp