Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork5.7k
Add new IsPalindrome implementation#1046
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
raklaptudirm merged 1 commit intoTheAlgorithms:masterfromHereBeAndre:add-new-ispalindrome-implementationJun 16, 2022
Uh oh!
There was an error while loading.Please reload this page.
Merged
Changes fromall commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Uh oh!
There was an error while loading.Please reload this page.
Jump to
Jump to file
Failed to load files.
Loading
Uh oh!
There was an error while loading.Please reload this page.
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,36 @@ | ||
| /** | ||
| * @function isPalindromeIterative | ||
| * @description isPalindromeIterative function checks whether the provided input is palindrome or not | ||
| * @param {String | Number} x - The input to check | ||
| * @return {boolean} - Input is palindrome or not | ||
| * @see [Palindrome](https://en.wikipedia.org/wiki/Palindrome) | ||
| */ | ||
| /* | ||
| * Big-O Analysis | ||
| * Time Complexity | ||
| - O(N) on average and worst case scenario as input is traversed in linear fashion | ||
| - O(N) on best case scenario, even when input has length of 1, because toString() method takes O(N) | ||
| * Space Complexity | ||
| - O(1) | ||
| */ | ||
| export function isPalindromeIterative (x) { | ||
| if (typeof x !== 'string' && typeof x !== 'number') { | ||
| throw new TypeError('Input must be a string or a number') | ||
| } | ||
| // Convert x to string whether it's number or string | ||
| const string = x.toString() | ||
| const length = string.length | ||
| if (length === 1) return true | ||
| // Apply two pointers technique to compare first and last elements on each iteration | ||
| for (let start = 0, end = length - 1; start < end; start++, end--) { | ||
| // Early return if compared items are different, input is not a palindrome | ||
| if (string[start] !== string[end]) return false | ||
| } | ||
| // If early return in condition inside for loop is not reached, then input is palindrome | ||
| return true | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,33 @@ | ||
| import { isPalindromeIterative } from '../IsPalindrome' | ||
| describe('isPalindrome', () => { | ||
| it('expects to return true with empty string', () => { | ||
| expect(isPalindromeIterative('')).toEqual(true) | ||
| }) | ||
| it('expects to return true when length of input is 1', () => { | ||
| const numberInput = 6 | ||
| const stringInput = 'a' | ||
| expect(isPalindromeIterative(numberInput)).toEqual(true) | ||
| expect(isPalindromeIterative(stringInput)).toEqual(true) | ||
| }) | ||
| it('expects to return true when input is palindrome', () => { | ||
| expect(isPalindromeIterative(121)).toEqual(true) | ||
| expect(isPalindromeIterative('yooy')).toEqual(true) | ||
| expect(isPalindromeIterative('19noon91')).toEqual(true) | ||
| expect(isPalindromeIterative('!*tyyt*!')).toEqual(true) | ||
| }) | ||
| it('expects to return false when input is not palindrome', () => { | ||
| expect(isPalindromeIterative('hello')).toEqual(false) | ||
| expect(isPalindromeIterative(189)).toEqual(false) | ||
| expect(isPalindromeIterative('!*98[!')).toEqual(false) | ||
| }) | ||
| it('expects to throw error when input is not a string or a number', () => { | ||
| expect(() => isPalindromeIterative(undefined)).toThrowError() | ||
| expect(() => isPalindromeIterative({ key: 'val' })).toThrowError() | ||
| expect(() => isPalindromeIterative([])).toThrowError() | ||
| }) | ||
| }) |
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.