- Notifications
You must be signed in to change notification settings - Fork20.8k
Optimize Factorial Algorithm (Iterative Implementation) and Add Comprehensive JUnit Test Suite#7145
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Open
trishajp38-source wants to merge5 commits intoTheAlgorithms:masterChoose a base branch fromtrishajp38-source:improve-factorial
base:master
Could not load branches
Branch not found:{{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline, and old review comments may become outdated.
Open
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
… iterative factorial with full test suite
codecov-commenter commentedNov 29, 2025 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@## master #7145 +/- ##========================================= Coverage 78.56% 78.56%+ Complexity 6794 6791 -3========================================= Files 762 761 -1 Lines 22520 22517 -3 Branches 4429 4428 -1 =========================================- Hits 17693 17691 -2 Misses 4115 4115+ Partials 712 711 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Author
trishajp38-source commentedNov 29, 2025
All CI checks have passed. |
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR improves the existing
Factorialimplementation in thedivideandconquerpackage by replacing the recursive algorithm with an optimized iterative version. The new implementation reduces space complexity, avoids recursion overhead, and prevents stack overflow for moderately large inputs.In addition, this PR adds a comprehensive JUnit test suite to validate correctness, edge cases, performance behavior, and relative improvement compared to the original recursive approach.
✔ Algorithm Improvements
✔ Test Suite Added (
FactorialTest.java)The added JUnit test suite covers:
1. Basic Correctness
IllegalArgumentException2. Performance & Analysis
3. Demonstrating Algorithmic Improvement
Why This PR Is Valuable
Thank you for reviewing this contribution!