Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

added all the temperature converter static methods#7021

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Draft
Bhavan-Prakash wants to merge1 commit intoTheAlgorithms:master
base:master
Choose a base branch
Loading
fromBhavan-Prakash:fix/issue-6936/temperature_converter

Conversation

@Bhavan-Prakash
Copy link

Features Implemented

  • Celsius ↔ Fahrenheit
  • Celsius ↔ Kelvin
  • Fahrenheit ↔ Kelvin
  • Kelvin ↔ Celsius

All formulas are implemented with precision up to 0.001 tolerance.

Testing

All JUnit test cases passed successfully inIntelliJ IDEA usingJUnit 5.

Reference

  • I have readCONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized it.
  • All filenames are in PascalCase.
  • All functions and variable names follow Java naming conventions.
  • All new algorithms have a URL in their comments that points to Wikipedia or other similar explanations.
  • All new code is formatted withclang-format -i --style=file path/to/your/file.java

@codecov-commenter
Copy link

Codecov Report

❌ Patch coverage is85.71429% with1 line in your changes missing coverage. Please review.
✅ Project coverage is 78.34%. Comparing base (0837424) to head (e84202a).

Files with missing linesPatch %Lines
...healgorithms/conversions/TemperatureConverter.java85.71%1 Missing⚠️
Additional details and impacted files
@@            Coverage Diff            @@##             master    #7021   +/-   ##=========================================  Coverage     78.34%   78.34%- Complexity     6621     6627    +6=========================================  Files           747      748    +1       Lines         22036    22043    +7       Branches       4322     4322           =========================================+ Hits          17264    17270    +6- Misses         4085     4086    +1  Partials        687      687

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report?Share it here.

🚀 New features to boost your workflow:
  • ❄️Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@vil02
Copy link
Member

@Bhavan-Prakash: it seems to be already implemented inUnitConversions.java.

@Bhavan-Prakash
Copy link
Author

@Bhavan-Prakash: it seems to be already implemented inUnitConversions.java.

thanks for notifing me , i wasnt aware that the issue has been already implemented but why did you guys didnt closed this issue?

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@DenizAltunkapanDenizAltunkapanAwaiting requested review from DenizAltunkapanDenizAltunkapan will be requested when the pull request is marked ready for reviewDenizAltunkapan is a code owner

@yanglbmeyanglbmeAwaiting requested review from yanglbmeyanglbme will be requested when the pull request is marked ready for reviewyanglbme is a code owner

@alxkmalxkmAwaiting requested review from alxkmalxkm will be requested when the pull request is marked ready for reviewalxkm is a code owner

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Bhavan-Prakash@codecov-commenter@vil02
[8]ページ先頭
©2009-2025 Movatter.jp