Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Fixed Type conversion error in BloomFilter.java Added RemoveStars and ComplexNumberMultiplication#6678

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Open
SwarritSrivastava wants to merge10 commits intoTheAlgorithms:master
base:master
Choose a base branch
Loading
fromSwarritSrivastava:remove-stars-complex-mult

Conversation

SwarritSrivastava
Copy link

@SwarritSrivastavaSwarritSrivastava commentedOct 6, 2025•
edited
Loading

  • I have readCONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized it.
  • All filenames are in PascalCase.
  • All functions and variable names follow Java naming conventions.
  • All new algorithms have a URL in their comments that points to Wikipedia or other similar explanations.
  • All new code is formatted withclang-format -i --style=file path/to/your/file.java

What does this PR do?

Adds two new string algorithms:

  1. RemoveStars

    • Removes each '*' and its closest non-star character to the left.
    • Example: "abbc**def*g" → "abdeg"

  2. ComplexNumberMultiplication

    • Multiplies two complex numbers represented as strings.
    • Example: "1+1i" * "1+1i" → "0+2i"

Checklist

  • Added Javadoc comments
  • Added JUnit tests
  • Code passes Checkstyle, PMD, and SpotBugs
  • Verified locally withmvn clean verify

This is my contribution for Hacktoberfest 2025

@codecov-commenter
Copy link

codecov-commenter commentedOct 6, 2025•
edited
Loading

Codecov Report

❌ Patch coverage is62.79070% with16 lines in your changes missing coverage. Please review.
✅ Project coverage is 75.77%. Comparing base (3eb521b) to head (c495f3d).

Files with missing linesPatch %Lines
...rithms/datastructures/bloomfilter/BloomFilter.java20.00%8 Missing and 8 partials⚠️
Additional details and impacted files
@@             Coverage Diff              @@##             master    #6678      +/-   ##============================================- Coverage     75.80%   75.77%   -0.03%- Complexity     5804     5810       +6============================================  Files           705      707       +2       Lines         19846    19888      +42       Branches       3851     3862      +11     ============================================+ Hits          15045    15071      +26- Misses         4218     4226       +8- Partials        583      591       +8

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report?Share it here.

🚀 New features to boost your workflow:
  • ❄️Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@SwarritSrivastavaSwarritSrivastava marked this pull request as draftOctober 7, 2025 07:38
@SwarritSrivastavaSwarritSrivastava changed the titleAdded RemoveStars and ComplexNumberMultiplicationAdded RemoveStars and ComplexNumberMultiplication Label:enhancementOct 7, 2025
@SwarritSrivastavaSwarritSrivastava changed the titleAdded RemoveStars and ComplexNumberMultiplication Label:enhancementFixed Type conversion error in BloomFilter.java Added RemoveStars and ComplexNumberMultiplicationOct 7, 2025
@SwarritSrivastavaSwarritSrivastava marked this pull request as ready for reviewOctober 7, 2025 07:41
@SwarritSrivastavaSwarritSrivastava marked this pull request as draftOctober 7, 2025 07:44
@SwarritSrivastavaSwarritSrivastava marked this pull request as ready for reviewOctober 7, 2025 07:44
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@DenizAltunkapanDenizAltunkapanAwaiting requested review from DenizAltunkapanDenizAltunkapan is a code owner

@yanglbmeyanglbmeAwaiting requested review from yanglbmeyanglbme is a code owner

@alxkmalxkmAwaiting requested review from alxkmalxkm is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

2 participants
@SwarritSrivastava@codecov-commenter
[8]ページ先頭
©2009-2025 Movatter.jp