Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

testing: improving test coverageDisjointSetUnionTest#6394

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Open
alxkm wants to merge7 commits intoTheAlgorithms:master
base:master
Choose a base branch
Loading
fromalxkm:test/DisjointSetUnionTest

Conversation

alxkm
Copy link
Contributor

@alxkmalxkm commentedJul 16, 2025
edited
Loading

  • Basic union/find: Verifies correct parent and rank after multiple unions.
  • Single node: Confirms findSet() returns the node itself for isolated nodes.
  • Union of connected nodes: Ensures repeated unions maintain correct root.
  • Rank increase: Validates rank updates correctly when merging equal-rank trees.
  • Multiple makeSets: Confirms unique sets are created with correct initial parents.
  • Path compression: Checks that findSet() flattens tree by updating parent pointers.
  • I have readCONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized it.
  • All filenames are in PascalCase.
  • All functions and variable names follow Java naming conventions.
  • All new algorithms have a URL in their comments that points to Wikipedia or other similar explanations.
  • All new code is formatted withclang-format -i --style=file path/to/your/file.java

@codecov-commenter
Copy link

codecov-commenter commentedJul 16, 2025
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.65%. Comparing base(5c6d3c3) to head(b96d036).

Additional details and impacted files
@@             Coverage Diff              @@##             master    #6394      +/-   ##============================================- Coverage     74.66%   74.65%   -0.01%+ Complexity     5459     5458       -1============================================  Files           682      682                Lines         19010    19010                Branches       3670     3670              ============================================- Hits          14193    14192       -1  Misses         4258     4258- Partials        559      560       +1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report?Share it here.

🚀 New features to boost your workflow:
  • ❄️Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@DenizAltunkapan
Copy link
Collaborator

@alxkm do you know why the build is failing?

@alxkm
Copy link
ContributorAuthor

@DenizAltunkapan thank you. There was spotbug plugin issue, which was missed before. Now it is fixed.

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@DenizAltunkapanDenizAltunkapanAwaiting requested review from DenizAltunkapanDenizAltunkapan is a code owner

@yanglbmeyanglbmeAwaiting requested review from yanglbmeyanglbme is a code owner

@vil02vil02Awaiting requested review from vil02vil02 is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

3 participants
@alxkm@codecov-commenter@DenizAltunkapan

[8]ページ先頭

©2009-2025 Movatter.jp