Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

refactor: cleanupGenerateSubsets#6373

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged

Conversation

alxkm
Copy link
Contributor

@alxkmalxkm commentedJul 12, 2025•
edited
Loading

  • Added JavaDocs to class and methods
  • Renamed doRecursion to generateSubsets for clarity
  • Improved variable names for readability
  • Enforced utility class pattern with private constructor
  • Added comments to explain recursion logic
  • I have readCONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized it.
  • All filenames are in PascalCase.
  • All functions and variable names follow Java naming conventions.
  • All new algorithms have a URL in their comments that points to Wikipedia or other similar explanations.
  • All new code is formatted withclang-format -i --style=file path/to/your/file.java

@codecov-commenter
Copy link

codecov-commenter commentedJul 12, 2025•
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.64%. Comparing base(910d5b8) to head(70d96fd).

Additional details and impacted files
@@            Coverage Diff            @@##             master    #6373   +/-   ##=========================================  Coverage     74.64%   74.64%+ Complexity     5444     5443    -1=========================================  Files           682      682             Lines         18999    18998    -1       Branches       3668     3668           =========================================  Hits          14181    14181+ Misses         4261     4259    -2- Partials        557      558    +1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report?Share it here.

🚀 New features to boost your workflow:
  • ❄️Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@alxkmalxkm changed the titlerefactor: cleanup GenerateSubsetsrefactor: cleanupGenerateSubsetsJul 12, 2025
Copy link
Collaborator

@DenizAltunkapanDenizAltunkapan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Your cleanups are very helpful, especially the lack of javadoc above the class suprises me

@DenizAltunkapanDenizAltunkapanenabled auto-merge (squash)July 13, 2025 09:15
@DenizAltunkapanDenizAltunkapan merged commit182118b intoTheAlgorithms:masterJul 13, 2025
6 of 7 checks passed
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@DenizAltunkapanDenizAltunkapanDenizAltunkapan approved these changes

@yanglbmeyanglbmeAwaiting requested review from yanglbmeyanglbme is a code owner

@vil02vil02Awaiting requested review from vil02vil02 is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

3 participants
@alxkm@codecov-commenter@DenizAltunkapan
[8]ページ先頭
©2009-2025 Movatter.jp